[jira] [Commented] (OPENJPA-2754) update to latest dbcp and verify moving from maxActive to maxTotal

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731914#comment-16731914 ] 

ASF subversion and git services commented on OPENJPA-2754:
----------------------------------------------------------

Commit fa96d6df02ccb12eb15144e1c001f9783bcdd48e in openjpa's branch refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=fa96d6d ]

OPENJPA-2754 implement a workaround for the bug in commons-pool2

By setting maxIdle to > 0 we can work around the bug and
even pass your test with the old versions.


> update to latest dbcp and verify moving from maxActive to maxTotal
> ------------------------------------------------------------------
>
>                 Key: OPENJPA-2754
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2754
>             Project: OpenJPA
>          Issue Type: Task
>          Components: jdbc
>    Affects Versions: 3.0.0
>            Reporter: Mark Struberg
>            Priority: Major
>             Fix For: 3.0.1
>
>
> commons-dbcp 2 moved from maxActive to maxTotal 
> https://commons.apache.org/proper/commons-dbcp/
> https://commons.apache.org/proper/commons-dbcp/configuration.html
> But all across our build we still use MaxActive.
> Do we like to keep this? Do we (via reflection) don't care and users need to care for themselves if they switch?
> Do we do it right in our unit tests right now?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)