You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2024/04/09 04:58:08 UTC

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

Hello Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/21264

to review the following change.


Change subject: IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
......................................................................

IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

To avoid absolutely paths and keep it simple, optimize the default
configurations for packaging module by remove or change some entries.

At the same time, add license header to 'package/conf/*-site.xml' and
rename them to '*-site.xml.template' to force administrator making
configurations appropriate for their cluster.

Testing:
 - Manually deploy packages on Ubuntu22.04 and verify it.

Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Reviewed-on: http://gerrit.cloudera.org:8080/20928
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/rat_exclude_files.txt
M package/conf/catalogd_flags
D package/conf/core-site.xml
A package/conf/core-site.xml.template
D package/conf/fair-scheduler.xml
A package/conf/fair-scheduler.xml.template
D package/conf/hdfs-site.xml
A package/conf/hdfs-site.xml.template
D package/conf/hive-site.xml
A package/conf/hive-site.xml.template
M package/conf/impalad_flags
D package/conf/llama-site.xml
A package/conf/llama-site.xml.template
M package/conf/statestored_flags
14 files changed, 267 insertions(+), 117 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/21264/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-3.4.2
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Gerrit-Change-Number: 21264
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21264 )

Change subject: IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
......................................................................


Patch Set 1: Verified+1

Passed exhaustive tests in https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/19985


-- 
To view, visit http://gerrit.cloudera.org:8080/21264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-3.4.2
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Gerrit-Change-Number: 21264
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 09:41:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

Posted by "Xiang Yang (Code Review)" <ge...@cloudera.org>.
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21264 )

Change subject: IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-3.4.2
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Gerrit-Change-Number: 21264
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 09 Apr 2024 05:37:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21264 )

Change subject: IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
......................................................................

IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

To avoid absolutely paths and keep it simple, optimize the default
configurations for packaging module by remove or change some entries.

At the same time, add license header to 'package/conf/*-site.xml' and
rename them to '*-site.xml.template' to force administrator making
configurations appropriate for their cluster.

Testing:
 - Manually deploy packages on Ubuntu22.04 and verify it.

Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Reviewed-on: http://gerrit.cloudera.org:8080/20928
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/21264
Reviewed-by: Xiang Yang <yx...@126.com>
Reviewed-by: Zihao Ye <ey...@163.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M bin/rat_exclude_files.txt
M package/conf/catalogd_flags
D package/conf/core-site.xml
A package/conf/core-site.xml.template
D package/conf/fair-scheduler.xml
A package/conf/fair-scheduler.xml.template
D package/conf/hdfs-site.xml
A package/conf/hdfs-site.xml.template
D package/conf/hive-site.xml
A package/conf/hive-site.xml.template
M package/conf/impalad_flags
D package/conf/llama-site.xml
A package/conf/llama-site.xml.template
M package/conf/statestored_flags
14 files changed, 267 insertions(+), 117 deletions(-)

Approvals:
  Xiang Yang: Looks good to me, but someone else must approve
  Zihao Ye: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-3.4.2
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Gerrit-Change-Number: 21264
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.

Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/21264 )

Change subject: IMPALA-12362: (part-2/4) Optimize default configurations for packaging module.
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-3.4.2
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifda229b779a3d6fca647bb81fe23dd61ad7e5d66
Gerrit-Change-Number: 21264
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 08:26:47 +0000
Gerrit-HasComments: No