[GitHub] [incubator-opendal] BoWuGit commented on a diff in pull request #2909: fix: S3 copy error on non-ascii file path

["BoWuGit (via GitHub)" <gi...@apache.org>]

BoWuGit commented on code in PR #2909:
URL: https://github.com/apache/incubator-opendal/pull/2909#discussion_r1302612477


##########
core/src/services/s3/core.rs:
##########
@@ -433,7 +433,7 @@ impl S3Core {
         }
 
         let mut req = req
-            .header(constants::X_AMZ_COPY_SOURCE, percent_encode_path(&source))
+            .header(constants::X_AMZ_COPY_SOURCE, &source)

Review Comment:
   OK, I would compliment it later this week, I want to add UT for it originally, but didn't know how at first, and thought it's mocked as to not coveraged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org