You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/02/04 04:36:56 UTC

[GitHub] [samza] perkss opened a new pull request #1456: SAMZA-2616: Upgrade ZK Client.

perkss opened a new pull request #1456:
URL: https://github.com/apache/samza/pull/1456


   **Issues:** The current ZK Client versions are very old and contain security risks and bugs that have been fixed with newer versions of the libraries Samza uses. The current ZKClient library we use stops at 0.11 therefore any newer version of Zookeeper is a much bigger change. This upgrades to the latest version to improve Samza with minimal disruption.
    
   **Changes:** Describe major changes, listing each separately.
       1. Upgrade Zookeeper version 3.4.13
       2. Upgrade ZKClient version to 0.11
    
   **Tests:** Run the check-all tests. 
   **API Changes:** None
   **Upgrade Instructions:** None
   **Usage Instructions:** None


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
perkss commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-767026668


   @mynameborat thanks for the pointers. Will the travis job kick in? Was hoping to run it on the tests take a long time to run locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-766926121


   @perkss Thanks for picking this up and contributing to Samza.
   Can you please follow the PR guidelines outlined [here](https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines) and update the description?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-771214675


   > @perkss not sure why the Travis build stuck at queueing stage. I have manually resubmit the build and let's see whether it actually started.
   
   @nickpan47 I tried restarting it couple of times as well. It either seems to get stuck in submission or queuing. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
perkss commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-773036589


   @nickpan47 @mynameborat build is all green now. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-773043346


   > @nickpan47 @mynameborat build is all green now.
   
   Thanks for triggering one more build. Merged the PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-766926121


   @perkss Thanks for picking this up and contributing to Samza.
   Can you please follow the PR guidelines outlined [here](https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines) and update the description?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss closed pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
perkss closed pull request #1456:
URL: https://github.com/apache/samza/pull/1456


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat merged pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
mynameborat merged pull request #1456:
URL: https://github.com/apache/samza/pull/1456


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
perkss commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-767026668


   @mynameborat thanks for the pointers. Will the travis job kick in? Was hoping to run it on the tests take a long time to run locally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] nickpan47 commented on pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
nickpan47 commented on pull request #1456:
URL: https://github.com/apache/samza/pull/1456#issuecomment-771212596


   @perkss not sure why the Travis build stuck at queueing stage. I have manually resubmit the build and let's see whether it actually started.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] perkss closed pull request #1456: SAMZA-2616: Upgrade ZK Client.

Posted by GitBox <gi...@apache.org>.
perkss closed pull request #1456:
URL: https://github.com/apache/samza/pull/1456


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org