[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2810: API: Use delete instead of remove in actions for clarity

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2810:
URL: https://github.com/apache/iceberg/pull/2810#discussion_r668183222



##########
File path: api/src/main/java/org/apache/iceberg/actions/DeleteReachableFiles.java
##########
@@ -51,39 +51,39 @@
    *  @param executorService the service to use
    * @return this for method chaining
    */
-  RemoveReachableFiles executeDeleteWith(ExecutorService executorService);
+  DeleteReachableFiles executeDeleteWith(ExecutorService executorService);
 
   /**
    * Set the {@link FileIO} to be used for files removal
    *
    * @param io FileIO to use for files removal
    * @return this for method chaining
    */
-  RemoveReachableFiles io(FileIO io);
+  DeleteReachableFiles io(FileIO io);
 
   /**
    * The action result that contains a summary of the execution.
    */
   interface Result {
 
     /**
-     * Returns the number of data files removed.
+     * Returns the number of deleted data files.
      */
-    long removedDataFilesCount();
+    long deletedDataFilesCount();

Review comment:
       Now it matches the naming in `ExpireSnapshots`.
   The downside is that we will add `deletedDeleteFilesCount` in the future. I can live with that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org