You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/04/07 01:20:14 UTC

[GitHub] storm pull request #2591: STORM-2979: WorkerHooks EOFException during run_wo...

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2591#discussion_r179904186
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
    @@ -585,6 +588,8 @@
     (defserverfn mk-worker [conf shared-mq-context storm-id assignment-id port worker-id]
       (log-message "Launching worker for " storm-id " on " assignment-id ":" port " with id " worker-id
                    " and conf " conf)
    +  ;; create an empty list to store deserialized hooks
    +  (def deserialized-hooks (java.util.ArrayList.))
    --- End diff --
    
    It would be better to include this in `worker-data` so that it can be reused at any time. Please add this to the returning recursive-map in `worker-data` function, and refer it from other functions.


---