You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/23 22:25:48 UTC
[kudu-CR](branch-1.15.x) [java] utility to detect sanitizer type used for kudu CLI
Hello Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/17492
to review the following change.
Change subject: [java] utility to detect sanitizer type used for kudu CLI
......................................................................
[java] utility to detect sanitizer type used for kudu CLI
This patch adds a new test utility to determine the type of the C++
sanitizer type used by the kudu CLI binary, if any. The new utility is
added into the kudu-test-utils package. I found it's useful to find
whether the mini-cluster binaries are built with TSAN/ASAN sanitizers,
so it's possible to skip heavy test scenarios which are not stable when
running against binaries built with ASAN/TSAN support.
I didn't add any tests, but this functionality is going to be used
in a follow-up patch.
Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Reviewed-on: http://gerrit.cloudera.org:8080/17487
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 6a0752420fdf46b821038d2f789cc9742a2ac864)
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryInfo.java
1 file changed, 80 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/17492/1
--
To view, visit http://gerrit.cloudera.org:8080/17492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Gerrit-Change-Number: 17492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.15.x) [java] utility to detect sanitizer type used for kudu CLI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17492 )
Change subject: [java] utility to detect sanitizer type used for kudu CLI
......................................................................
Patch Set 1: Verified+1
unrelated test failures due to clock synchronization issues:
Unrelated test failures due to intermittent clock sync issues and already bound port for embedded webserver:
1) testScanNonCoveredTable(org.apache.kudu.client.TestKuduClient)
java.io.IOException: failed to start masters: Unable to start Master at index 0: /tmp/dist-test-taskGT6z2J/build/tsan/bin/kudu: process exited with non-zero status 1
unavailable: Cannot initialize clock: timed out waiting for clock synchronisation: wallclock is not synchronized: no valid NTP responses yet
23:54:51.841 [DEBUG - main] (MiniKuduCluster.java:182) Response: error {
code: RUNTIME_ERROR
message: "failed to start masters: Unable to start Master at index 0: /tmp/dist-test-taskGT6z2J/build/tsan/bin/kudu: process exited with non-zero status 1"
}
TabletCopyITest.TestTabletCopyFollowerWithHigherTerm:
Runtime error: Webserver: could not start on address 127.20.91.129:37373: set_ports_option: cannot bind to 127.20.91.129:37373: 98 (Address already in use)
/home/jenkins-slave/workspace/kudu-branch-1.15.x/0/src/kudu/integration-tests/tablet_copy-itest.cc:604: Failure
Failed
--
To view, visit http://gerrit.cloudera.org:8080/17492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Gerrit-Change-Number: 17492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 24 May 2021 02:02:20 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [java] utility to detect sanitizer type used for kudu CLI
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17492 )
Change subject: [java] utility to detect sanitizer type used for kudu CLI
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Gerrit-Change-Number: 17492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 23 May 2021 23:33:57 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [java] utility to detect sanitizer type used for kudu CLI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [java] utility to detect sanitizer type used for kudu CLI
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Gerrit-Change-Number: 17492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [java] utility to detect sanitizer type used for kudu CLI
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17492 )
Change subject: [java] utility to detect sanitizer type used for kudu CLI
......................................................................
[java] utility to detect sanitizer type used for kudu CLI
This patch adds a new test utility to determine the type of the C++
sanitizer type used by the kudu CLI binary, if any. The new utility is
added into the kudu-test-utils package. I found it's useful to find
whether the mini-cluster binaries are built with TSAN/ASAN sanitizers,
so it's possible to skip heavy test scenarios which are not stable when
running against binaries built with ASAN/TSAN support.
I didn't add any tests, but this functionality is going to be used
in a follow-up patch.
Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Reviewed-on: http://gerrit.cloudera.org:8080/17487
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 6a0752420fdf46b821038d2f789cc9742a2ac864)
Reviewed-on: http://gerrit.cloudera.org:8080/17492
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryInfo.java
1 file changed, 80 insertions(+), 0 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I08c978ecda7321038b97c5c885914c02122606c1
Gerrit-Change-Number: 17492
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)