You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/05/07 06:50:50 UTC
[GitHub] [iotdb] luciferz2021 opened a new pull request, #5821: Fix order by when aligned by device
luciferz2021 opened a new pull request, #5821:
URL: https://github.com/apache/iotdb/pull/5821
## Description
In version 0.13, when aligned by device, the records are sorted within device so the order is wrong.
It is fixed by update the implementation of AlignByDeviceDataSet.java
<hr>
This PR has:
- [ x ] been self-reviewed.
- [ x ] concurrent read
- [ x ] concurrent write
- [ x ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
- AlignByDeviceDataSet.java
- RawDataQueryPlan.java
- ServerTimeGenerator.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Alima777 commented on pull request #5821: Fix order by when aligned by device
Posted by GitBox <gi...@apache.org>.
Alima777 commented on PR #5821:
URL: https://github.com/apache/iotdb/pull/5821#issuecomment-1120162806
Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is sorted by device order first, and then by timestamp order. Therefore, **it's not a wrong order, but the current standard we defined.**
However, this definition does not satisfy some users' cases indeed. But if modified simply as you did, maybe other users still want the result order before. So we will redefine the semantics in the next version and support these two order at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] luciferz2021 commented on pull request #5821: Fix order by when aligned by device
Posted by GitBox <gi...@apache.org>.
luciferz2021 commented on PR #5821:
URL: https://github.com/apache/iotdb/pull/5821#issuecomment-1120183112
> Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is **sorted by device order first, and then by timestamp order.** Therefore, **it's not a wrong order, but the current standard we defined.**
>
> However, this standard does not satisfy some users' cases indeed. But **if modified simply as you did, maybe other users still want the result order before.** So we have been tried to redefine the semantics in the next version and support these two order at the same time.
>
> Thank you for the contribution anyway :D
Is there any document or web page that describes the new semantics? We want to use this feature in our system. If the semantics have been redefined, we can adopt to it first in our inner version to minimize the effort to upgrade later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on pull request #5821: Fix order by when aligned by device
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on PR #5821:
URL: https://github.com/apache/iotdb/pull/5821#issuecomment-1214541678
> > Hi, in align by device query, we see each device as one relational table with (device + timestamp) as the primary key. When querying multiple devices, the result is **sorted by device order first, and then by timestamp order.** Therefore, **it's not a wrong order, but the current standard we defined.**
> > However, this standard does not satisfy some users' cases indeed. But **if modified simply as you did, maybe other users still want the result order before.** So we have been tried to redefine the semantics in the next version and support these two order at the same time.
> > Thank you for the contribution anyway :D
>
> Is there any document or web page that describes the new semantics? We want to use this feature in our system. If the semantics have been redefined, we can adopt to it first in our inner version to minimize the effort to upgrade later.
It seems that docs doesn't explain this semantics, we will add it soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 closed pull request #5821: Fix order by when aligned by device
Posted by GitBox <gi...@apache.org>.
JackieTien97 closed pull request #5821: Fix order by when aligned by device
URL: https://github.com/apache/iotdb/pull/5821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org