You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/21 17:20:33 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #21728: Create template for failing tests.

damccorm commented on code in PR #21728:
URL: https://github.com/apache/beam/pull/21728#discussion_r1028325706


##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]

Review Comment:
   ```suggestion
   labels: ["bug", "awaiting triage", "failing test"]
   ```
   
   We switched this label



##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+  - octocat
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.

Review Comment:
   Could you please match the sentences in https://github.com/apache/beam/blob/aa4c076b6253028ca795dd7b25e4088f9334a023/.github/ISSUE_TEMPLATE/bug.yml



##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+  - octocat
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: What happened?
+      description: Please name which test is failing.
+      placeholder: |
+          If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+          If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+  - type: dropdown
+    id: failure
+    attributes:
+      label: Issue Failure
+      options:
+      - "Test is flaky"
+      - "Test is continually failing"
+    required: true

Review Comment:
   ```suggestion
       validations:
         required: true
   ```



##########
.github/ISSUE_TEMPLATE/failing_test.yml:
##########
@@ -0,0 +1,171 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: Failing Test
+description: Report a failing test
+title: "[Failing Test]: "
+labels: ["bug", "awaiting triage", "test-failures"]
+assignees:
+  - octocat
+body:
+  - type: markdown
+    attributes:
+      value: |
+        Thanks for taking the time to report this test failure! Once you've created an issue, you can self-assign by commenting `.take-issue` and you can close by commenting `.close-issue`.
+  - type: textarea
+    id: what-happened
+    attributes:
+      label: What happened?
+      description: Please name which test is failing.
+      placeholder: |
+          If possible include: when the test started failing, a jenkins link, and any initial debugging you've done.
+
+          If this isn't a bug and you have a question or support request, please email user@apache.beam.com with a description of the problem instead of opening this issue.
+  - type: dropdown
+    id: failure
+    attributes:
+      label: Issue Failure
+      options:
+      - "Test is flaky"
+      - "Test is continually failing"

Review Comment:
   ```suggestion
         - "Failure: Test is flaky"
         - "Failure: Test is continually failing"
   ```
   
   This will allow the bot to pick it up since your config is:
   
   ```
   - valueFor: 'Failure'
     contains: 'Test is flaky'
     addLabels: ['flaky', 'tests']
   - valueFor: 'Failure'
     contains: 'Test is continually failing'
     addLabels: ['permared', 'failing test', 'tests']
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org