You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2012/11/09 17:16:11 UTC
[jira] [Created] (BOOKKEEPER-459) Move metastore mock
implementation to src/test/main
Ivan Kelly created BOOKKEEPER-459:
-------------------------------------
Summary: Move metastore mock implementation to src/test/main
Key: BOOKKEEPER-459
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Ivan Kelly
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-459) Rename metastore mock
implementation to InMemory implementation
Posted by "Jiannan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jiannan Wang updated BOOKKEEPER-459:
------------------------------------
Summary: Rename metastore mock implementation to InMemory implementation (was: Move metastore mock implementation to src/test/java)
> Rename metastore mock implementation to InMemory implementation
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Move metastore mock
implementation to src/test/java
Posted by "Jiannan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494653#comment-13494653 ]
Jiannan Wang commented on BOOKKEEPER-459:
-----------------------------------------
Sijie and I discussed on this issue before, and we think in some cases, an in-memory metastore implementation might be used. So the mock implementation is moved out from test component.
> Move metastore mock implementation to src/test/java
> ---------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Rename metastore mock
implementation to InMemory implementation
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509602#comment-13509602 ]
Hudson commented on BOOKKEEPER-459:
-----------------------------------
Integrated in bookkeeper-trunk #837 (See [https://builds.apache.org/job/bookkeeper-trunk/837/])
BOOKKEEPER-459: Rename metastore mock implementation to InMemory implementation (jiannan via ivank) [remove directory] (Revision 1416526)
BOOKKEEPER-459: Rename metastore mock implementation to InMemory implementation (jiannan via ivank) (Revision 1416519)
Result = UNSTABLE
ivank :
Files :
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock
ivank :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/InMemoryMetaStore.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/InMemoryMetastoreCursor.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/InMemoryMetastoreTable.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetaStore.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetastoreCursor.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock/MockMetastoreTable.java
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/test/java/org/apache/bookkeeper/metastore/TestMetaStore.java
> Rename metastore mock implementation to InMemory implementation
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-459.diff
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Rename metastore mock
implementation to InMemory implementation
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508682#comment-13508682 ]
Hadoop QA commented on BOOKKEEPER-459:
--------------------------------------
Testing JIRA BOOKKEEPER-459
WARNING: Running test-patch on a dirty local svn workspace
Patch <a href="/jira/secure/attachment/12555742/BOOKKEEPER-459.diff">/jira/secure/attachment/12555742/BOOKKEEPER-459.diff</a> downloaded at Mon Dec 3 11:41:48 UTC 2012
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than 120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:green}+1 TESTS{color}
. Tests run: 430
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/65/
> Rename metastore mock implementation to InMemory implementation
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-459.diff
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-459) Rename metastore mock
implementation to InMemory implementation
Posted by "Jiannan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jiannan Wang updated BOOKKEEPER-459:
------------------------------------
Attachment: BOOKKEEPER-459.diff
Upload a patch, also post it in review board: https://reviews.apache.org/r/8315/
> Rename metastore mock implementation to InMemory implementation
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-459.diff
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Rename metastore mock
implementation to InMemory implementation
Posted by "Jiannan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508708#comment-13508708 ]
Jiannan Wang commented on BOOKKEEPER-459:
-----------------------------------------
Diff file cannot contain removing directory action. I almost forget to mention that directory "bookkeeper-server/src/main/java/org/apache/bookkeeper/metastore/mock" should be removed manually for this patch.
> Rename metastore mock implementation to InMemory implementation
> ---------------------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
> Attachments: BOOKKEEPER-459.diff
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Move metastore mock
implementation to src/test/java
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507910#comment-13507910 ]
Ivan Kelly commented on BOOKKEEPER-459:
---------------------------------------
Could we rename it to InMemory rather than Mock metastore implementation then?
> Move metastore mock implementation to src/test/java
> ---------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-459) Move metastore mock
implementation to src/test/java
Posted by "Jiannan Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508255#comment-13508255 ]
Jiannan Wang commented on BOOKKEEPER-459:
-----------------------------------------
Okay, I'll rename it.
> Move metastore mock implementation to src/test/java
> ---------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-459) Move metastore mock
implementation to src/test/java
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-459:
----------------------------------
Description: It's a test component, so it should really be in the test tree.
Assignee: Jiannan Wang
Summary: Move metastore mock implementation to src/test/java (was: Move metastore mock implementation to src/test/main)
> Move metastore mock implementation to src/test/java
> ---------------------------------------------------
>
> Key: BOOKKEEPER-459
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-459
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server, hedwig-server
> Reporter: Ivan Kelly
> Assignee: Jiannan Wang
> Fix For: 4.2.0
>
>
> It's a test component, so it should really be in the test tree.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira