You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/02 13:46:43 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #37772: [SPARK-40163][CORE][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert`
LuciferYang opened a new pull request, #37772:
URL: https://github.com/apache/spark/pull/37772
### What changes were proposed in this pull request?
This pr is a minor fix of https://github.com/apache/spark/pull/37478, just change to use Junit api to assert in Java suite.
### Why are the changes needed?
In Java suites, should use JUnit API to make assertions.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GitHub Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #37772: [SPARK-40163][SQL][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert` in `JavaSparkSessionSuite.java`
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #37772: [SPARK-40163][SQL][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert` in `JavaSparkSessionSuite.java`
URL: https://github.com/apache/spark/pull/37772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #37772: [SPARK-40163][SQL][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert` in `JavaSparkSessionSuite.java`
Posted by GitBox <gi...@apache.org>.
srowen commented on PR #37772:
URL: https://github.com/apache/spark/pull/37772#issuecomment-1235845541
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seunggabi commented on pull request #37772: [SPARK-40163][SQL][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert` in `JavaSparkSessionSuite.java`
Posted by GitBox <gi...@apache.org>.
seunggabi commented on PR #37772:
URL: https://github.com/apache/spark/pull/37772#issuecomment-1235844897
Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #37772: [SPARK-40163][CORE][TESTS][FOLLOWUP] Use Junit `Assert` api instead of Java `assert` in `JavaSparkSessionSuite.java`
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #37772:
URL: https://github.com/apache/spark/pull/37772#issuecomment-1235528340
cc @seunggabi @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org