You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hubgeter (via GitHub)" <gi...@apache.org> on 2023/11/01 10:46:12 UTC
[PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
hubgeter opened a new pull request, #26238:
URL: https://github.com/apache/doris/pull/26238
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790210908
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #26238:
URL: https://github.com/apache/doris/pull/26238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #26238:
URL: https://github.com/apache/doris/pull/26238#discussion_r1379637114
##########
regression-test/suites/query_p0/system/test_query_sys_tables.groovy:
##########
@@ -87,12 +87,53 @@ suite("test_query_sys_tables", "query,p0") {
// test files
// have no impl
+ qt_desc_files """desc `information_schema`.`files` """
+ qt_query_files """ select * from `information_schema`.`files` """
+
+ // test schema_privileges
+ // have no impl
+ qt_desc_schema_privileges """desc `information_schema`.`schema_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.schema_privileges where GRANTEE = "root%" """
+
+ // test table_privileges
+ // have no impl(fe:listTablePrivilegeStatus)
+ qt_desc_table_privileges """desc `information_schema`.`table_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.table_privileges """
+
// test partitions
// have no impl
+ qt_desc_partitions """ desc `information_schema`.`partitions` """
+ qt_select_partitions """ select * from `information_schema`.`partitions`; """
+
+
// test rowsets
- // have no tablet system table, add this later
+ qt_desc_rowsets """ desc information_schema.rowsets """
+ def rowsets_table_name = """ test_query_sys_db_1.test_query_rowset """
+ sql """ drop table if exists ${rowsets_table_name} """
+
+ sql """
+ create table ${rowsets_table_name}(
+ a int ,
+ b boolean ,
+ c string )
+ DISTRIBUTED BY HASH(`a`) BUCKETS 1
+ PROPERTIES (
+ "replication_num" = "1",
+ "disable_auto_compaction" = "true",
+ "enable_single_replica_compaction"="true"
+ );
+ """
+
+ List<List<Object>> rowsets_table_name_tablts = sql """ show tablets from ${rowsets_table_name} """
Review Comment:
```suggestion
List<List<Object>> rowsets_table_name_tablets = sql """ show tablets from ${rowsets_table_name} """
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1798601315
TeamCity be ut coverage result:
Function Coverage: 37.03% (8392/22665)
Line Coverage: 29.45% (67946/230738)
Region Coverage: 28.14% (35164/124977)
Branch Coverage: 24.92% (17967/72112)
Coverage Report: http://coverage.selectdb-in.cc/coverage/675952fad551cf79ade70bfec218a9344dc0e342_675952fad551cf79ade70bfec218a9344dc0e342/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1788750610
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790880480
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "BePPPower (via GitHub)" <gi...@apache.org>.
BePPPower commented on code in PR #26238:
URL: https://github.com/apache/doris/pull/26238#discussion_r1383347851
##########
regression-test/suites/query_p0/system/test_query_sys_tables.groovy:
##########
@@ -87,12 +87,53 @@ suite("test_query_sys_tables", "query,p0") {
// test files
// have no impl
+ qt_desc_files """desc `information_schema`.`files` """
+ qt_query_files """ select * from `information_schema`.`files` """
+
+ // test schema_privileges
+ // have no impl
+ qt_desc_schema_privileges """desc `information_schema`.`schema_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.schema_privileges where GRANTEE = "root%" """
+
+ // test table_privileges
+ // have no impl(fe:listTablePrivilegeStatus)
+ qt_desc_table_privileges """desc `information_schema`.`table_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.table_privileges """
+
// test partitions
// have no impl
+ qt_desc_partitions """ desc `information_schema`.`partitions` """
+ qt_select_partitions """ select * from `information_schema`.`partitions`; """
+
Review Comment:
we'd better use `order_qt` for select statement, rather than `qt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790248619
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.57 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162095895 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1788818801
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.97 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162152341 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790880387
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1803007266
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1798554457
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1788762918
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on code in PR #26238:
URL: https://github.com/apache/doris/pull/26238#discussion_r1380243265
##########
regression-test/suites/query_p0/system/test_query_sys_tables.groovy:
##########
@@ -87,12 +87,53 @@ suite("test_query_sys_tables", "query,p0") {
// test files
// have no impl
+ qt_desc_files """desc `information_schema`.`files` """
+ qt_query_files """ select * from `information_schema`.`files` """
+
+ // test schema_privileges
+ // have no impl
+ qt_desc_schema_privileges """desc `information_schema`.`schema_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.schema_privileges where GRANTEE = "root%" """
+
+ // test table_privileges
+ // have no impl(fe:listTablePrivilegeStatus)
+ qt_desc_table_privileges """desc `information_schema`.`table_privileges` """
+ qt_select_schema_privileges """ select * from information_schema.table_privileges """
+
// test partitions
// have no impl
+ qt_desc_partitions """ desc `information_schema`.`partitions` """
+ qt_select_partitions """ select * from `information_schema`.`partitions`; """
+
+
// test rowsets
- // have no tablet system table, add this later
+ qt_desc_rowsets """ desc information_schema.rowsets """
+ def rowsets_table_name = """ test_query_sys_db_1.test_query_rowset """
+ sql """ drop table if exists ${rowsets_table_name} """
+
+ sql """
+ create table ${rowsets_table_name}(
+ a int ,
+ b boolean ,
+ c string )
+ DISTRIBUTED BY HASH(`a`) BUCKETS 1
+ PROPERTIES (
+ "replication_num" = "1",
+ "disable_auto_compaction" = "true",
+ "enable_single_replica_compaction"="true"
+ );
+ """
+
+ List<List<Object>> rowsets_table_name_tablts = sql """ show tablets from ${rowsets_table_name} """
Review Comment:
Only the two tables information_schema.statistics and information_schema.table_constraints have no test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1798631841
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.11 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162507896 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790223583
TeamCity be ut coverage result:
Function Coverage: 37.38% (8481/22686)
Line Coverage: 29.74% (68605/230702)
Region Coverage: 28.38% (35487/125031)
Branch Coverage: 25.12% (18117/72114)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5f3c72e6f6d1b03697419e023d26d29a7e34aefa_5f3c72e6f6d1b03697419e023d26d29a7e34aefa/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1788777528
TeamCity be ut coverage result:
Function Coverage: 37.44% (8489/22676)
Line Coverage: 29.82% (68936/231205)
Region Coverage: 28.29% (35692/126146)
Branch Coverage: 25.17% (18286/72658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cae71e005623bbbdfa1792f541e4239e3c88a296_cae71e005623bbbdfa1792f541e4239e3c88a296/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1790201973
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](information_schema)fix bug that metadata_name_ids error tableid and append information_schema case. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26238:
URL: https://github.com/apache/doris/pull/26238#issuecomment-1798569876
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org