[jira] [Commented] (HAWQ-672) Add python module pygresql back into hawq workspace

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HAWQ-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270021#comment-15270021 ] 

ASF GitHub Bot commented on HAWQ-672:
-------------------------------------

Github user radarwave commented on the pull request:

    https://github.com/apache/incubator-hawq/pull/606#issuecomment-216724353
  
    Looks good to me. +1


> Add python module pygresql back into hawq workspace
> ---------------------------------------------------
>
>                 Key: HAWQ-672
>                 URL: https://issues.apache.org/jira/browse/HAWQ-672
>             Project: Apache HAWQ
>          Issue Type: Bug
>            Reporter: Paul Guo
>            Assignee: Lei Chang
>
> HAWQ-271 (Remove external python modules) removed a lot of external python modules besides pygresql. Now to install pygresql, we have to hack a bit as  https://cwiki.apache.org/confluence/display/HAWQ/Build+and+Install said, i.e. install postgresql package at first and then remove it after installing pygresql, else pip will report error like "pg_config: command not found". Since installing postgresql is a bit painful and the workaround seems to be ugly, we could revert the code change for pygresql for HAWQ-271. That is to say, users do not need to install pygresql themselves. Note that we did some hack to upstream pygresql.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)