You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@axis.apache.org by "Olivier Mengué (JIRA)" <ji...@apache.org> on 2010/03/04 11:14:27 UTC

[jira] Created: (AXIS2C-1459) dist-hook in top Makefile.am removes .svn

dist-hook in top Makefile.am removes .svn
-----------------------------------------

                 Key: AXIS2C-1459
                 URL: https://issues.apache.org/jira/browse/AXIS2C-1459
             Project: Axis2-C
          Issue Type: Improvement
          Components: build system (Unix/Linux)
    Affects Versions: 1.6.0, Current (Nightly)
            Reporter: Olivier Mengué
            Priority: Minor


The top Makefile.am contains the following lines:

dist-hook:
	rm -rf `find $(distdir)/ -type d -name .svn`
...

This makes the process of creating patches of the build system unnecessary harder, as it requires to have a separate checkout elsewhere.

I understand the need to avoid to have .svn directory in releases archives. But the problem may be at a higher level: releases should not be made from an 'svn checkout' but instead from an 'svn export' with controlled revision number (a release tag), to avoid making a package using files which are missing from the repository.

So please remove the 'rm .svn' line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


[jira] Commented: (AXIS2C-1459) dist-hook in top Makefile.am removes .svn

Posted by "Olivier Mengué (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2C-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841228#action_12841228 ] 

Olivier Mengué commented on AXIS2C-1459:
----------------------------------------

See the automake manual as a reference:
http://sources.redhat.com/automake/automake.html#Checking-the-Distribution

> dist-hook in top Makefile.am removes .svn
> -----------------------------------------
>
>                 Key: AXIS2C-1459
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1459
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: build system (Unix/Linux)
>    Affects Versions: 1.6.0, Current (Nightly)
>            Reporter: Olivier Mengué
>            Priority: Minor
>
> The top Makefile.am contains the following lines:
> dist-hook:
> 	rm -rf `find $(distdir)/ -type d -name .svn`
> ...
> This makes the process of creating patches of the build system unnecessary harder, as it requires to have a separate checkout elsewhere.
> I understand the need to avoid to have .svn directory in releases archives. But the problem may be at a higher level: releases should not be made from an 'svn checkout' but instead from an 'svn export' with controlled revision number (a release tag), to avoid making a package using files which are missing from the repository.
> So please remove the 'rm .svn' line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


[jira] Commented: (AXIS2C-1459) dist-hook in top Makefile.am removes .svn

Posted by "Olivier Mengué (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2C-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841228#action_12841228 ] 

Olivier Mengué commented on AXIS2C-1459:
----------------------------------------

See the automake manual as a reference:
http://sources.redhat.com/automake/automake.html#Checking-the-Distribution

> dist-hook in top Makefile.am removes .svn
> -----------------------------------------
>
>                 Key: AXIS2C-1459
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1459
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: build system (Unix/Linux)
>    Affects Versions: 1.6.0, Current (Nightly)
>            Reporter: Olivier Mengué
>            Priority: Minor
>
> The top Makefile.am contains the following lines:
> dist-hook:
> 	rm -rf `find $(distdir)/ -type d -name .svn`
> ...
> This makes the process of creating patches of the build system unnecessary harder, as it requires to have a separate checkout elsewhere.
> I understand the need to avoid to have .svn directory in releases archives. But the problem may be at a higher level: releases should not be made from an 'svn checkout' but instead from an 'svn export' with controlled revision number (a release tag), to avoid making a package using files which are missing from the repository.
> So please remove the 'rm .svn' line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


[jira] Resolved: (AXIS2C-1459) dist-hook in top Makefile.am removes .svn

Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Samisa Abeysinghe resolved AXIS2C-1459.
---------------------------------------

    Resolution: Won't Fix

If someone wants to provide patches, they got to use an svn checkout. 

You cannot develop against a source pack. 

Allowing having .svn in the source pack leads to unnecessary complications. 

> dist-hook in top Makefile.am removes .svn
> -----------------------------------------
>
>                 Key: AXIS2C-1459
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1459
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: build system (Unix/Linux)
>    Affects Versions: 1.6.0, Current (Nightly)
>            Reporter: Olivier Mengué
>            Priority: Minor
>
> The top Makefile.am contains the following lines:
> dist-hook:
> 	rm -rf `find $(distdir)/ -type d -name .svn`
> ...
> This makes the process of creating patches of the build system unnecessary harder, as it requires to have a separate checkout elsewhere.
> I understand the need to avoid to have .svn directory in releases archives. But the problem may be at a higher level: releases should not be made from an 'svn checkout' but instead from an 'svn export' with controlled revision number (a release tag), to avoid making a package using files which are missing from the repository.
> So please remove the 'rm .svn' line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org


[jira] Resolved: (AXIS2C-1459) dist-hook in top Makefile.am removes .svn

Posted by "Samisa Abeysinghe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2C-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Samisa Abeysinghe resolved AXIS2C-1459.
---------------------------------------

    Resolution: Won't Fix

If someone wants to provide patches, they got to use an svn checkout. 

You cannot develop against a source pack. 

Allowing having .svn in the source pack leads to unnecessary complications. 

> dist-hook in top Makefile.am removes .svn
> -----------------------------------------
>
>                 Key: AXIS2C-1459
>                 URL: https://issues.apache.org/jira/browse/AXIS2C-1459
>             Project: Axis2-C
>          Issue Type: Improvement
>          Components: build system (Unix/Linux)
>    Affects Versions: 1.6.0, Current (Nightly)
>            Reporter: Olivier Mengué
>            Priority: Minor
>
> The top Makefile.am contains the following lines:
> dist-hook:
> 	rm -rf `find $(distdir)/ -type d -name .svn`
> ...
> This makes the process of creating patches of the build system unnecessary harder, as it requires to have a separate checkout elsewhere.
> I understand the need to avoid to have .svn directory in releases archives. But the problem may be at a higher level: releases should not be made from an 'svn checkout' but instead from an 'svn export' with controlled revision number (a release tag), to avoid making a package using files which are missing from the repository.
> So please remove the 'rm .svn' line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: c-dev-help@axis.apache.org