[GitHub] [kyuubi] xiaoyuandajian commented on issue #4057: [Bug] shell script about the var wrong

[GitBox <gi...@apache.org>]

xiaoyuandajian commented on issue #4057:
URL: https://github.com/apache/kyuubi/issues/4057#issuecomment-1381505314

   @pan3793 hi, i fix some file bug, could you assign the issue to me? there are some modify info
   fix-#4057 info: modify the shellcheck errors file in ./bin
   1. "$@" is a array, we want use string to compare. so modify "$@" => "$*"
   2. `tty` mean execute the command, we can use $(tty) replace it
   3. param $# is a number, compare number should use -gt/-lt,not >/<
   4. not sure the /bin/kyuubi line 63 'exit -1' need modify? so the directory bin only have a shellcheck note in /bin/kyuubi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org