You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/18 01:12:18 UTC
[GitHub] [airflow] potiuk opened a new pull request #13731: Gets rid of all the docker cli tools in Breeze.
potiuk opened a new pull request #13731:
URL: https://github.com/apache/airflow/pull/13731
The docker cli tools caused more trouble than benefits.
Replaced the last two (azure and aws) with installation to
"/files" directory so that they survive breeze restart.
Also added --reinstall to installation command for all tools
so that it is easier to reinstall them.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13731: Gets rid of all the docker cli tools in Breeze.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13731:
URL: https://github.com/apache/airflow/pull/13731#issuecomment-761947307
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13731: Gets rid of all the docker cli tools in Breeze.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13731:
URL: https://github.com/apache/airflow/pull/13731#discussion_r559292138
##########
File path: .pre-commit-config.yaml
##########
@@ -418,6 +418,7 @@ repos:
name: Check Shell scripts syntax correctness
language: docker_image
entry: koalaman/shellcheck:stable -x -a
+ exclude: activate$
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13731: Gets rid of all the docker cli tools in Breeze.
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13731:
URL: https://github.com/apache/airflow/pull/13731#discussion_r559291426
##########
File path: .pre-commit-config.yaml
##########
@@ -418,6 +418,7 @@ repos:
name: Check Shell scripts syntax correctness
language: docker_image
entry: koalaman/shellcheck:stable -x -a
+ exclude: activate$
Review comment:
Is this file excluded by default because it is not added to the repository and is located in the `/files` directory?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #13731: Gets rid of all the docker cli tools in Breeze.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #13731:
URL: https://github.com/apache/airflow/pull/13731#discussion_r559292038
##########
File path: .pre-commit-config.yaml
##########
@@ -418,6 +418,7 @@ repos:
name: Check Shell scripts syntax correctness
language: docker_image
entry: koalaman/shellcheck:stable -x -a
+ exclude: activate$
Review comment:
Ah. leftover. I remve it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13731: Gets rid of all the docker cli tools in Breeze.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13731:
URL: https://github.com/apache/airflow/pull/13731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org