You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/10 16:41:20 UTC

[GitHub] [geode] kohlmu-pivotal commented on a change in pull request #5234: GEODE-8190 - Completed GeodeJarModuleFinder to register and load Modules.

kohlmu-pivotal commented on a change in pull request #5234:
URL: https://github.com/apache/geode/pull/5234#discussion_r438264180



##########
File path: gradle/java.gradle
##########
@@ -74,9 +74,9 @@ gradle.taskGraph.whenReady({ graph ->
     }
     jar.metaInf {
       from("$rootDir/geode-assembly/src/main/dist/LICENSE")
-      if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
-        from("$rootDir/NOTICE")
-      }
+//      if (jar.source.filter({ it.name.contains('NOTICE') }).empty) {
+//        from("$rootDir/NOTICE")
+//      }

Review comment:
       Any idea why these lines were commented out




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org