[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6655: Kinesis implementation Part 1: Rename partitionId to partitionGroupId

[GitBox <gi...@apache.org>]

KKcorps commented on a change in pull request #6655:
URL: https://github.com/apache/incubator-pinot/pull/6655#discussion_r589935144



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
##########
@@ -222,10 +222,10 @@ public void setUpNewTable(TableConfig tableConfig, IdealState idealState) {
 
     long currentTimeMs = getCurrentTimeMs();
     Map<String, Map<String, String>> instanceStatesMap = idealState.getRecord().getMapFields();
-    for (int partitionId = 0; partitionId < numPartitions; partitionId++) {

Review comment:
       nit: should we rename `numPartitions` to `numPartitionGroups` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org