[GitHub] jacobrosenthal opened a new pull request #1285: move sensor_itf to driver_itf WIP please evaluate

[GitBox <gi...@apache.org>]

jacobrosenthal opened a new pull request #1285: move sensor_itf to driver_itf WIP please evaluate
URL: https://github.com/apache/mynewt-core/pull/1285
 
 
   The sensor interface model is really nice way to properly remove state from driver implementations and a missing piece in the driver model.
   
   Further Ive been pushing that sensors should rather be a wrapper around slimmer driver implementations.
   
   I can and will break this out, but wanted it all in one place for discussion and testing. This pr:
   * brings what I think is the bare minimum from sensor over to a driver pkg 
   * converts the lis2dxxx sensors.
   * removes all sensor stuff from the drv2605 which was using sensor just to get the itf.
   
   Note the major change was making the _config take a driver_itf instead of a os_dev object. This is the major change and Im not sure how to fix it differently other than adding a third arg like init.
   
   But It does brings up an argument Ive made before, no drivers/sensors (excepting pwm, uart, adc) utilize os_dev's open/close handlers and we now have sensor (or driver in this case) interface locking.. are we getting our memorys worth with os_devs in sensors/drivers?? 
   
   
   Thoughts?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services