You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "bzp2010 (via GitHub)" <gi...@apache.org> on 2025/08/23 08:55:47 UTC
[PR] fix: docker entrypoint remove stream_worker_events.sock if exists [apisix]
bzp2010 opened a new pull request, #12546:
URL: https://github.com/apache/apisix/pull/12546
### Description
If the container exits abnormally, Nginx cannot properly clean up the unix domain socket files it is listening on. When the container is restarted, the startup will fail because the files still exist, preventing the container from starting.
Therefore, we check and delete the files in the entrypoint script of the Docker container. This includes the conf server and event broker.
However, this overlooks the event broker UDS file used by the stream subsystem, so when using TCP/UDP proxies, startup may still fail.
This PR fixes the issue by checking whether the file exists and deleting it if it does.
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: docker entrypoint remove stream_worker_events.sock if exists [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on PR #12546:
URL: https://github.com/apache/apisix/pull/12546#issuecomment-3219617882
@moonming
I don't think we've made that decision yet. If we plan to do so, we need a statement indicating that we are switching from Debian to Ubuntu.
Otherwise, (as is currently the case) we need to maintain both versions.
In any case, this change is for the dev image, so it should not be controversial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: docker entrypoint remove stream_worker_events.sock if exists [apisix]
Posted by "jakeslee (via GitHub)" <gi...@apache.org>.
jakeslee commented on PR #12546:
URL: https://github.com/apache/apisix/pull/12546#issuecomment-3334817165
I want to know when this change will be released?
I killed the docker instance of APISIX, then starts the container(simulates host power failure). The APISIX container failed to start with many `Address already in use` logs.
```shell
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua init_etcd
trying to initialize the data of etcd
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
nginx: [emerg] bind() to unix:/usr/local/apisix/logs/stream_worker_events.sock failed (98: Address already in use)
2025/09/25 15:36:40 [emerg] 1#1: still could not bind()
nginx: [emerg] still could not bind(
```
The issue will be fixed when I replace image `apache/apisix:latest` with `apache/apisix:dev`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: docker entrypoint remove stream_worker_events.sock if exists [apisix]
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 merged PR #12546:
URL: https://github.com/apache/apisix/pull/12546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org