You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "WweiL (via GitHub)" <gi...@apache.org> on 2023/02/21 19:39:23 UTC

[GitHub] [spark] WweiL commented on pull request #40073: [SPARK-42484] [SQL] UnsafeRowUtils better error message

WweiL commented on PR #40073:
URL: https://github.com/apache/spark/pull/40073#issuecomment-1438998141

   Some tests always fail with 
   ```
   112 did not equal 104 Invalid stopIndex of a query context. Actual:SQLQueryContext(Some(1),Some(15),Some(15),Some(112),Some(select id from hive.`/home/runner/work/oss-spark/oss-spark/target/tmp/spark-9ff647b3-c1b5-449d-ae54-19a7f3baff9d`),None,None)
   ```
   I guess that's because my folder name is `oss-spark`. The two `oss-` contains 8 chars, that's equal to 112 - 104.
   
   https://github.com/WweiL/oss-spark/actions/runs/4235566927/jobs/7359363624
   
   So I changed the [hard-coded length here](https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala#L1410) to a variable-length one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org