[GitHub] [iceberg] kbendick commented on a change in pull request #3203: Spark: Leverage SPARK-32056 in Spark 3.1

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #3203:
URL: https://github.com/apache/iceberg/pull/3203#discussion_r719842927



##########
File path: spark3/src/main/scala/org/apache/spark/sql/catalyst/utils/PlanUtils.scala
##########
@@ -54,14 +55,28 @@ object PlanUtils {
         Integer.TYPE)
       .build()
 
+  def numShufflePartitions(conf: SQLConf): Option[Int] = {
+    if (Spark3VersionUtil.isSpark30) {
+      Some(conf.numShufflePartitions)
+    } else {
+      // SPARK-32056: Coalesce partitions for repartition by expressions when AQE is enabled
+      None

Review comment:
       Do we need to check if AQE is enabled? E.g. if a user disables AQE, should this still return `Some(conf.numShufflePartitions)`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org