Re: [PR] KAFKA-19738: Add unit tests for OffsetsRequestManager ListOffsets request building [kafka]

["peterzdhuang (via GitHub)" <gi...@apache.org>]

peterzdhuang commented on code in PR #22667:
URL: https://github.com/apache/kafka/pull/22667#discussion_r3887477809


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManagerTest.java:
##########
@@ -469,6 +471,52 @@ public void testRequestPartiallyFailsWithRetriableError_RetrySucceeds() throws E
         verifyRequestSuccessfullyCompleted(fetchOffsetsFuture, expectedOffsets);
     }
 
+    @Test
+    public void testListOffsetsRetriedToNewLeaderAfterMetadataUpdate() throws ExecutionException,

Review Comment:
   Hey Evan, take a look at my new changes, it should be addressed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org