You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2011/03/09 08:58:59 UTC
[jira] Resolved: (WICKET-3513) AbstractDefaultAjaxBehavior
generates broken Javascript
[ https://issues.apache.org/jira/browse/WICKET-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3513.
-----------------------------------
Resolution: Invalid
Assignee: Igor Vaynberg
> AbstractDefaultAjaxBehavior generates broken Javascript
> -------------------------------------------------------
>
> Key: WICKET-3513
> URL: https://issues.apache.org/jira/browse/WICKET-3513
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.4.16, 1.5-RC2
> Environment: n/a
> Reporter: Stijn de Witt
> Assignee: Igor Vaynberg
> Labels: javascript
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> org.apache.wicket.ajax.AbstractDefaultAjaxBehavior#generateCallbackScript is generating Javascript code of the form:
> if (condition) {Wicket.hideIncrementally()} var wcall = <ajax call code>; Wicket.showIncrementally();
> It should either be:
> if (condition) {Wicket.hideIncrementally(); var wcall = <ajax call code>; Wicket.showIncrementally(); }
> (notice the moved closing brace of the if-block)
> or:
> if (condition) {Wicket.hideIncrementally()} var wcall = <ajax call code>; if (condition) {Wicket.showIncrementally()}
> Any way, the calls to Wicket.hideIncrementally and Wicket.showIncrementally should be balanced. Now they are not, which may trigger, in some circumstances (when 'condition' == true) a call to showIncrementally when there was never a call to hideIncrementally, disturbing the balance in such a way that the busy indicator keeps spinning forever.
> Also see my related posts on the Wicket User List:
> Possible bug in org.apache.wicket.ajax.AbstractDefaultAjaxBehavior
> http://apache-wicket.1842946.n4.nabble.com/Possible-bug-in-org-apache-wicket-ajax-AbstractDefaultAjaxBehavior-td3335256.html
> With kind regards,
> -Stijn
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira