You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/09/30 19:06:05 UTC
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request
#655: MINIFICPP-1049 - Fix make docker
bakaid commented on a change in pull request #655: MINIFICPP-1049 - Fix make docker
URL: https://github.com/apache/nifi-minifi-cpp/pull/655#discussion_r329739013
##########
File path: docker/Dockerfile
##########
@@ -76,7 +76,7 @@ ENV MINIFI_HOME $MINIFI_BASE_DIR/nifi-minifi-cpp-${MINIFI_VERSION}
RUN cd ${MINIFI_BASE_DIR} \
&& mkdir build \
&& cd build \
- && cmake -DOPENSSL_FORCE_SHARED=true -DDISABLE_JEMALLOC=ON -DSTATIC_BUILD= -DSKIP_TESTS=true -DENABLE_JNI=ON .. \
+ && cmake -DDISABLE_JEMALLOC=ON -DSTATIC_BUILD= -DSKIP_TESTS=true -DENABLE_JNI=ON .. \
Review comment:
`OPENSSL_FORCE_SHARED` no longer makes sense (doesn't hurt either, but it was confusing).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services