[GitHub] [airflow] houqp commented on a change in pull request #13299: fix 422 invalid value error caused by long k8s pod name

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #13299:
URL: https://github.com/apache/airflow/pull/13299#discussion_r552420231



##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -370,6 +368,10 @@ def construct_pod(  # pylint: disable=too-many-arguments
         except Exception:  # pylint: disable=W0703
             image = kube_image
 
+        task_id = make_safe_label_value(task_id)
+        dag_id = make_safe_label_value(dag_id)
+        scheduler_job_id = make_safe_label_value(scheduler_job_id)

Review comment:
       scheduler_job_id is annotated as `scheduler_job_id: str,` in construct_pod's function signature as well as in `AirflowKubernetesScheduler` and many other class/function type signatures, do we need to correct the type annotation for all of them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org