You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jesperct (via GitHub)" <gi...@apache.org> on 2026/06/05 13:59:25 UTC
[PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
jesperct opened a new pull request, #40805:
URL: https://github.com/apache/superset/pull/40805
### SUMMARY
The toast notification container (`ToastPresenter`) is a `position: fixed` element that spans most of the viewport height (`height: calc(100vh - 100px)`) at a high z-index. A plain `div` captures pointer events across its entire box, so even when only one toast is visible at the bottom, the container's empty area sat on top of any controls in the same vertical strip and swallowed their clicks. In practice this blocked the dashboard header's **Save** / **Edit dashboard** buttons while a toast was on screen, until the toast timed out or was dismissed.
The fix sets `pointer-events: none` on the container and re-enables `pointer-events: auto` on each `.toast`. Clicks now fall through the empty area to the controls underneath, while individual toasts stay fully interactive (close button, content scrolling).
### BEFORE/AFTER
**Before:** While a toast is visible in a bottom corner, buttons in the same vertical strip (e.g. the dashboard Save / Edit buttons) cannot be clicked. Interaction only resumes once the toast disappears.
**After:** The empty area of the toast container passes clicks through, so those buttons respond immediately while toasts are still showing. Toasts themselves remain clickable and dismissable.
### TESTING INSTRUCTIONS
1. Open a dashboard.
2. Trigger a toast near a corner (for example, save the dashboard, or any action that shows a success/info toast).
3. While the toast is still visible, click a button in the same vertical strip as the toast container (e.g. **Edit dashboard** / **Save** in the header).
- Before this change: the click is swallowed until the toast disappears.
- After this change: the button responds immediately.
Unit tests in `ToastPresenter.test.tsx` assert the container renders with `pointer-events: none` and each toast with `pointer-events: auto`.
### ADDITIONAL INFORMATION
- [x] Changes UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #40805:
URL: https://github.com/apache/superset/pull/40805#discussion_r3364313612
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.test.tsx:
##########
@@ -47,3 +47,12 @@ test('should pass removeToast to the Toast component', async () => {
fireEvent.click(getAllByTestId('close-button')[0]);
await waitFor(() => expect(removeToast).toHaveBeenCalledTimes(1));
});
+
+test('presenter caps its height with max-height so it hugs the toasts', () => {
+ // A fixed `height` would make the fixed overlay span the viewport and block
+ // controls underneath it; `max-height` lets it shrink to the toasts while
+ // still scrolling when they overflow.
+ const presenter = setup().container.querySelector('#toast-presenter');
+ expect(presenter).toHaveStyleRule('max-height', 'calc(100vh - 100px)');
+ expect(presenter).not.toHaveStyleRule('height', 'calc(100vh - 100px)');
Review Comment:
`querySelector('#toast-presenter')` can return null; adding an explicit presence assertion makes failures clearer and avoids running style matchers on a null value.
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -37,7 +37,9 @@ const StyledToastPresenter = styled.div<VisualProps>(
z-index: ${theme.zIndexPopupBase + 1};
word-break: break-word;
- height: calc(100vh - 100px);
+ /* Cap height for scrolling, but hug the toasts so the fixed overlay does not
+ reserve the full viewport and block controls underneath it. */
+ max-height: calc(100vh - 100px);
Review Comment:
The PR description and testing instructions state the fix uses `pointer-events: none` on the presenter container and `pointer-events: auto` on each toast. The actual code change here instead replaces a fixed `height` with `max-height` (and the new test asserts that), so the PR metadata no longer matches the implementation. Please update the PR description/title/testing steps to reflect the `max-height` approach (or adjust the code to match the documented `pointer-events` behavior).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4634370929
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #40805:
URL: https://github.com/apache/superset/pull/40805#discussion_r3363172308
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -39,6 +39,9 @@ const StyledToastPresenter = styled.div<VisualProps>(
height: calc(100vh - 100px);
+ /* Full-height overlay: pass clicks through empty area; toasts re-enable below. */
+ pointer-events: none;
Review Comment:
**Suggestion:** Setting `pointer-events: none` on the entire fixed presenter also disables pointer interaction with the presenter's own scroll container (including scrollbar thumb/track), so when many toasts overflow the viewport users can lose direct mouse-based scrolling of the toast stack. Keep click-through behavior only for truly empty overlay space (for example via a separate wrapper layer) while preserving pointer events on the actual scrollable presenter element. [css layout issue]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
- ❌ Users cannot drag toast stack scrollbar with mouse.
- ⚠️ Reviewing many historical toasts becomes cumbersome when overflowing viewport.
- ⚠️ Embedded dashboards toast UX degraded for long-running sessions.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. In the embedded dashboard entrypoint at
`superset-frontend/src/embedded/index.tsx:69-86`, note that `EmbeddedRoute` renders
`<ToastContainer position="top" />` (line 85), which in turn connects Redux
`messageToasts` state to `ToastPresenter` via `ToastContainer` in
`src/components/MessageToasts/ToastContainer.tsx:21-28`.
2. `ToastPresenter` renders the fixed, full-height scroll container `StyledToastPresenter`
in `src/components/MessageToasts/ToastPresenter.tsx:27-53`, which is styled with `height:
calc(100vh - 100px);` and `overflow-y: auto;` (lines 40 and 49), so when many toasts exist
(from `messageToastsReducer` in `src/components/MessageToasts/reducers.ts:36-45`), the
container becomes vertically scrollable with a scrollbar (`&::-webkit-scrollbar` at lines
67-83).
3. The same styled block sets `pointer-events: none;` on the presenter at
`ToastPresenter.tsx:42-43`, and only re-enables pointer events on `.toast` children at
`ToastPresenter.tsx:95-102` (`.toast { pointer-events: auto; ... }`), meaning the scroll
container box and its scrollbar track/thumb (not children) do not receive pointer events
while the empty overlay area passes clicks through to underlying UI.
4. Run the frontend, navigate to any route that mounts `<ToastContainer />` (e.g. the
embedded dashboard route above or Storybook `InteractiveCopyToClipboard` which renders
`<ToastContainer />` in
`src/components/CopyToClipboard/CopyToClipboard.stories.tsx:7-11`), trigger enough toasts
via any `addSuccessToast`/`addDangerToast` usage (e.g. dashboard save success at
`src/dashboard/actions/dashboardState.ts:545-547`), so that the toast stack overflows and
shows a scrollbar, then attempt to click or drag the scrollbar thumb of
`#toast-presenter`: because `pointer-events: none` is set on the scroll container, those
mouse interactions are ignored or passed to underlying content instead of scrolling the
toast stack, preventing direct mouse-based scrollbar control of the toasts.
```
</details>
[Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c04b0b1194dd4401abffa3a70f92dd46&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c04b0b1194dd4401abffa3a70f92dd46&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/components/MessageToasts/ToastPresenter.tsx
**Line:** 42:43
**Comment:**
*Css Layout Issue: Setting `pointer-events: none` on the entire fixed presenter also disables pointer interaction with the presenter's own scroll container (including scrollbar thumb/track), so when many toasts overflow the viewport users can lose direct mouse-based scrolling of the toast stack. Keep click-through behavior only for truly empty overlay space (for example via a separate wrapper layer) while preserving pointer events on the actual scrollable presenter element.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40805&comment_hash=165f053ddfc187d085428674d9d7315e0cf0bcaa259c08dc1f815ac512404c23&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40805&comment_hash=165f053ddfc187d085428674d9d7315e0cf0bcaa259c08dc1f815ac512404c23&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4632496974
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40805?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.07%. Comparing base ([`45a6164`](https://app.codecov.io/gh/apache/superset/commit/45a616439bbfa7224a2e2e0713697fd009aaef67?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2d1fa97`](https://app.codecov.io/gh/apache/superset/commit/2d1fa970fd77654bbc83da8a66ef683a9cb53789?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40805 +/- ##
=======================================
Coverage 64.07% 64.07%
=======================================
Files 2664 2664
Lines 143831 143831
Branches 33084 33084
=======================================
Hits 92160 92160
Misses 50062 50062
Partials 1609 1609
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40805/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40805/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.63% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/40805?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4635757179
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40805:
URL: https://github.com/apache/superset/pull/40805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "jesperct (via GitHub)" <gi...@apache.org>.
jesperct commented on code in PR #40805:
URL: https://github.com/apache/superset/pull/40805#discussion_r3364673341
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -37,7 +37,9 @@ const StyledToastPresenter = styled.div<VisualProps>(
z-index: ${theme.zIndexPopupBase + 1};
word-break: break-word;
- height: calc(100vh - 100px);
+ /* Cap height for scrolling, but hug the toasts so the fixed overlay does not
+ reserve the full viewport and block controls underneath it. */
+ max-height: calc(100vh - 100px);
Review Comment:
The description and title were updated to the max-height approach after the rework, so they now match the code. The pointer-events wording is gone.
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.test.tsx:
##########
@@ -47,3 +47,12 @@ test('should pass removeToast to the Toast component', async () => {
fireEvent.click(getAllByTestId('close-button')[0]);
await waitFor(() => expect(removeToast).toHaveBeenCalledTimes(1));
});
+
+test('presenter caps its height with max-height so it hugs the toasts', () => {
+ // A fixed `height` would make the fixed overlay span the viewport and block
+ // controls underneath it; `max-height` lets it shrink to the toasts while
+ // still scrolling when they overflow.
+ const presenter = setup().container.querySelector('#toast-presenter');
+ expect(presenter).toHaveStyleRule('max-height', 'calc(100vh - 100px)');
+ expect(presenter).not.toHaveStyleRule('height', 'calc(100vh - 100px)');
Review Comment:
Added an explicit `expect(presenter).toBeInTheDocument()` before the style assertions in 418f736.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "jesperct (via GitHub)" <gi...@apache.org>.
jesperct commented on code in PR #40805:
URL: https://github.com/apache/superset/pull/40805#discussion_r3364495548
##########
superset-frontend/src/components/MessageToasts/ToastPresenter.tsx:
##########
@@ -39,6 +39,9 @@ const StyledToastPresenter = styled.div<VisualProps>(
height: calc(100vh - 100px);
+ /* Full-height overlay: pass clicks through empty area; toasts re-enable below. */
+ pointer-events: none;
Review Comment:
Confirmed, and reworked the fix to avoid this. Instead of pointer-events:none on the scroll container (which would have disabled scrollbar dragging), I changed the container's `height: calc(100vh - 100px)` to `max-height`, so it hugs its toasts and the fixed overlay no longer covers the buttons. overflow-y:auto still scrolls the stack when toasts overflow, and the scrollbar stays interactive. Fixed in f975f91.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4632369521
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): let clicks pass through the toast container's empty area [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4632448876
<!-- Bito Reply -->
The flagged issue is correct. Setting `pointer-events: none` on the `StyledToastPresenter` container disables all pointer interactions, including the scrollbar, which prevents users from scrolling through a long list of toasts. To resolve this, you should set `pointer-events: auto` on the container itself, but ensure the container does not block clicks in its empty space. A common approach is to use a transparent overlay or ensure the container only occupies the space necessary for the toasts, or alternatively, use `pointer-events: auto` on the container and handle click-through behavior by checking if the click target is the container itself versus a child toast.
**superset-frontend/src/components/MessageToasts/ToastPresenter.tsx**
```
height: calc(100vh - 100px);
/* Allow pointer events on the container to enable scrolling */
pointer-events: auto;
display: flex;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(toasts): stop the toast overlay from covering controls behind it [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40805:
URL: https://github.com/apache/superset/pull/40805#issuecomment-4642752808
**Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org