[GitHub] [ozone] guihecheng commented on a diff in pull request #3385: HDDS-6543. [Merge rocksdb in datanode] BlockDeletingService adaptation for schema v3 containers.

[GitBox <gi...@apache.org>]

guihecheng commented on code in PR #3385:
URL: https://github.com/apache/ozone/pull/3385#discussion_r867665944


##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/TestBlockDeletingService.java:
##########
@@ -236,6 +241,26 @@ private void createPendingDeleteBlocksSchema2(int numOfBlocksPerContainer,
       int txnID, long containerID, int numOfChunksPerBlock, ChunkBuffer buffer,
       ChunkManager chunkManager, KeyValueContainer container,
       KeyValueContainerData data) {
+    createPendingDeleteBlocksViaTxn(numOfBlocksPerContainer, txnID,
+        containerID, numOfChunksPerBlock, buffer, chunkManager,
+        container, data);
+  }
+
+  @SuppressWarnings("checkstyle:parameternumber")
+  private void createPendingDeleteBlocksSchema3(int numOfBlocksPerContainer,

Review Comment:
   Yes, it is, here I just intend to keep the schema check style of function in `createToDeleteBlocks` aligned, but I could remove one of the identical functions and use the lower level function directly when we have schema v2 || v3. 



##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/statemachine/background/BlockDeletingService.java:
##########
@@ -516,4 +547,10 @@ public int getPriority() {
       return priority;
     }
   }
+
+  private interface Deleter {
+    void apply(Table<?, DeletedBlocksTransaction> deleteTxnsTable,
+        BatchOperation batch, long txnID)
+        throws IOException;

Review Comment:
   Sure, I'll merge it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org