[GitHub] [hive] yongzhi commented on a change in pull request #3105: [WIP]HIVE-21456: Thrift over Http for Hive Metastore

[GitBox <gi...@apache.org>]

yongzhi commented on a change in pull request #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r827532603



##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java
##########
@@ -271,6 +286,31 @@ public static TTransport getSSLSocket(String host, int port, int loginTimeout,
     return getSSLSocketWithHttps(tSSLSocket);
   }
 
+  public static THttpClient getHttpSSLSocket(String httpsUrl, String trustStorePath,
+      String trustStorePasswd, String trustStoreAlgorithm, String trustStoreType)

Review comment:
       I did not find http server related code, for example, the server ssl  socket that can handle http request. Will the servlet handle that?

##########
File path: itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java
##########
@@ -67,6 +67,12 @@ public static void setMetastoreSslConf(HiveConf conf) {
             KEY_STORE_TRUST_STORE_PASSWORD);
   }
 
+  public static void setMetastoreHttpsConf(HiveConf conf) {
+    setMetastoreSslConf(conf);
+    MetastoreConf.setVar(conf, MetastoreConf.ConfVars.TRANSPORT_MODE, "http");

Review comment:
       Should it be THRIFT_TRANSPORT_MODE?

##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
##########
@@ -591,6 +592,31 @@ public void renamePartition(String catName, String dbname, String tableName, Lis
     client.rename_partition_req(req);
   }
 
+  /**
+   * The config parameter can be like "path", "/path", "/path/", "path/*", "/path1/path2/*" and so on.
+   * httpPath should end up as "/*", "/path/*" or "/path1/../pathN/*"
+   * @param httpPath
+   * @return
+   */
+  private String getHttpPath(String httpPath) {

Review comment:
       It is duplicated and has no use, should be removed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org