You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 03:40:15 UTC
[PR] test(auth): deepen LoginVO serialization and data coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3271:
URL: https://github.com/apache/rocketmq-dashboard/pull/3271
## Summary
Extends the existing `LoginVOTest` (1 to 4 tests) to pin down the login response contract.
Added cases:
- `toString` omits the token field entirely (field name and value both absent);
- Jackson serialization drops a null token (`@JsonInclude(NON_NULL)`) while a present token is emitted, with `expiresIn` and the nested user payload always serialized;
- `@Data` equality/hashCode cover the nested `UserInfo`, so a different admin flag (or user) breaks equality.
## Why
The VO is the login response boundary; token redaction in logs, null-token JSON shape, and equality semantics are all client-visible contracts.
## Testing
`mvn -B test -Dtest=LoginVOTest` — 4/4 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(auth): deepen LoginVO serialization and data coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3271: test(auth): deepen LoginVO serialization and data coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org