You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/18 14:46:03 UTC
[GitHub] [kylin] nichunen opened a new pull request #1069: Prevent
uncontrolled data used in path expression
nichunen opened a new pull request #1069: Prevent uncontrolled data used in path expression
URL: https://github.com/apache/kylin/pull/1069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1069: Prevent uncontrolled
data used in path expression
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1069: Prevent uncontrolled data used in path expression
URL: https://github.com/apache/kylin/pull/1069#issuecomment-575907358
## Pull Request Test Coverage Report for [Build 5535](https://coveralls.io/builds/28188778)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* **6** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.003%**) to **27.509%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [core-metadata/src/main/java/org/apache/kylin/metadata/TableMetadataManager.java](https://coveralls.io/builds/28188778/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2FTableMetadataManager.java#L487) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-metadata/src/main/java/org/apache/kylin/metadata/TableMetadataManager.java](https://coveralls.io/builds/28188778/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2FTableMetadataManager.java#L488) | 1 | 62.19% |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28188778/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/28188778) |
| :-- | --: |
| Change from base [Build 5534](https://coveralls.io/builds/28186373): | -0.003% |
| Covered Lines: | 24134 |
| Relevant Lines: | 87730 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1069: Prevent uncontrolled
data used in path expression
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1069: Prevent uncontrolled data used in path expression
URL: https://github.com/apache/kylin/pull/1069
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1069: Prevent uncontrolled
data used in path expression
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1069: Prevent uncontrolled data used in path expression
URL: https://github.com/apache/kylin/pull/1069#issuecomment-575908067
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=h1) Report
> Merging [#1069](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b87753fa4b49d4016f846fc2e35a36d611d6c8b4?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1069 +/- ##
============================================
- Coverage 25.05% 25.05% -0.01%
Complexity 6223 6223
============================================
Files 1438 1438
Lines 87729 87730 +1
Branches 12257 12257
============================================
- Hits 21984 21981 -3
- Misses 63596 63599 +3
- Partials 2149 2150 +1
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/kylin/metadata/TableMetadataManager.java](https://codecov.io/gh/apache/kylin/pull/1069/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvVGFibGVNZXRhZGF0YU1hbmFnZXIuamF2YQ==) | `58.2% <0%> (-0.3%)` | `26 <0> (ø)` | |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1069/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=footer). Last update [b87753f...edbf375](https://codecov.io/gh/apache/kylin/pull/1069?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services