You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "arunpandianp (via GitHub)" <gi...@apache.org> on 2026/02/23 12:33:04 UTC

[PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

arunpandianp opened a new pull request, #37683:
URL: https://github.com/apache/beam/pull/37683

   The added experiment informs backend of the support and make jobs having this change eligible for state tag encoding v2.
   
   Post submit tests with v2 encoding passes and internal test suites pass with encoding v2.
   
   https://github.com/apache/beam/actions?query=workflow%3A%22%22PostCommit+Java+ValidatesRunner+Dataflow+Streaming+TagEncodingV2%22%22++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on code in PR #37683:
URL: https://github.com/apache/beam/pull/37683#discussion_r2840685838


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1309,6 +1320,8 @@ public DataflowPipelineJob run(Pipeline pipeline) {
         if (!experiments.contains("enable_windmill_service")) {
           experiments.add("enable_windmill_service");
         }
+        // TODO: The experiments added above are not included in the list of experiments sent to the

Review Comment:
   should we just remove the experiments settings here? I think that the options.setEnabledStreamingEngine probably is sufficient.



##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1299,6 +1299,17 @@ public DataflowPipelineJob run(Pipeline pipeline) {
     if (shouldActAsStreaming(pipeline)) {
       options.setStreaming(true);
 
+      {
+        List<String> experiments =
+            options.getExperiments() == null
+                ? new ArrayList<>()
+                : new ArrayList<>(options.getExperiments());
+        // Experiment marking that the harness supports tag encoding v2
+        // Backend will enable tag encoding v2 only if the harness supports it.
+        experiments.add("streaming_engine_state_tag_encoding_v2_supported");

Review Comment:
   should we guard doing this based upon the compatabilityversion option?
   
   IT could help in case someone starts on 2.Y with compatabilityversion 2.X because they think they might want to rollback to 2.X



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on code in PR #37683:
URL: https://github.com/apache/beam/pull/37683#discussion_r2840892544


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1299,6 +1299,17 @@ public DataflowPipelineJob run(Pipeline pipeline) {
     if (shouldActAsStreaming(pipeline)) {
       options.setStreaming(true);
 
+      {
+        List<String> experiments =
+            options.getExperiments() == null
+                ? new ArrayList<>()
+                : new ArrayList<>(options.getExperiments());
+        // Experiment marking that the harness supports tag encoding v2
+        // Backend will enable tag encoding v2 only if the harness supports it.
+        experiments.add("streaming_engine_state_tag_encoding_v2_supported");

Review Comment:
   Chatted offline. This change is only marking the beam version as eligible for the new encoding. There'll be a following change where encoding v2 will be enabled by default. Will add compatabilityVersion checks in the following change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on PR #37683:
URL: https://github.com/apache/beam/pull/37683#issuecomment-3945251839

   Thanks, fixed the failing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on code in PR #37683:
URL: https://github.com/apache/beam/pull/37683#discussion_r2840887267


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java:
##########
@@ -1309,6 +1320,8 @@ public DataflowPipelineJob run(Pipeline pipeline) {
         if (!experiments.contains("enable_windmill_service")) {
           experiments.add("enable_windmill_service");
         }
+        // TODO: The experiments added above are not included in the list of experiments sent to the

Review Comment:
   fixing it in https://github.com/apache/beam/pull/37684.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37683:
URL: https://github.com/apache/beam/pull/37683#issuecomment-3944504627

   ## Summary of Changes
   
   Hello @arunpandianp, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request introduces a mechanism to signal support for version 2 of state tag encoding within Dataflow Streaming jobs. By adding a specific experiment flag, the Dataflow runner explicitly communicates to the backend that it is capable of handling this new encoding, thereby enabling jobs to utilize the improved state tag encoding v2. This change is crucial for rolling out and testing the new encoding standard.
   
   ### Highlights
   
   * **Dataflow Streaming State Tag Encoding v2 Support**: An experiment flag `streaming_engine_state_tag_encoding_v2_supported` was added to Dataflow runner options. This flag informs the backend that the harness supports state tag encoding v2, making jobs eligible for this new feature.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   <details>
   <summary><b>Changelog</b></summary>
   
   * **runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java**
       * Added an experiment `streaming_engine_state_tag_encoding_v2_supported` to the Dataflow runner options when streaming is enabled.
       * Included a `TODO` comment regarding a missing `options.setExperiments` call for previously added experiments.
   </details>
   
   <details>
   <summary><b>Activity</b></summary>
   
   * Post-submit tests with v2 encoding passed.
   * Internal test suites passed with encoding v2.
   * A link to GitHub Actions workflow for validation was provided.
   </details>
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37683:
URL: https://github.com/apache/beam/pull/37683#issuecomment-3944516120

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle merged PR #37683:
URL: https://github.com/apache/beam/pull/37683


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "scwhittle (via GitHub)" <gi...@apache.org>.
scwhittle commented on PR #37683:
URL: https://github.com/apache/beam/pull/37683#issuecomment-3944958441

   Some test errors due to explicit experiment checking


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dataflow Streaming] Mark support for windmill state tag encoding v2 [beam]

Posted by "arunpandianp (via GitHub)" <gi...@apache.org>.
arunpandianp commented on PR #37683:
URL: https://github.com/apache/beam/pull/37683#issuecomment-3944510730

   R: @scwhittle 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org