You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/08/12 16:44:52 UTC
Review Request 51044: GEODE-1737: gfsh query on region that does not
exist may cause NPE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51044/
-----------------------------------------------------------
Review request for geode, anilkumar gingade and nabarun nag.
Repository: geode
Description
-------
If a query on a region did not exist, a null is returned. This causes an npe that needs to be checked for.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java ae87b72
Diff: https://reviews.apache.org/r/51044/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 51044: GEODE-1737: gfsh query on region that does
not exist may cause NPE
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51044/#review145634
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java (line 1315)
<https://reviews.apache.org/r/51044/#comment211949>
Can it be put as an else condition here? (as we are already doing the check here)
- nabarun nag
On Aug. 12, 2016, 4:44 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51044/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 4:44 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If a query on a region did not exist, a null is returned. This causes an npe that needs to be checked for.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java ae87b72
>
> Diff: https://reviews.apache.org/r/51044/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 51044: GEODE-1737: gfsh query on region that does
not exist may cause NPE
Posted by Jason Huynh <hu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51044/#review145636
-----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java (line 1315)
<https://reviews.apache.org/r/51044/#comment211951>
Oh interesting, it looks like this shouldn't be an issue after all. I'll remove this jira ticket. It was originally an issue for the GemFire product but it looks like someone already noticed and fixed it.
- Jason Huynh
On Aug. 12, 2016, 4:44 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51044/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 4:44 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If a query on a region did not exist, a null is returned. This causes an npe that needs to be checked for.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java ae87b72
>
> Diff: https://reviews.apache.org/r/51044/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 51044: GEODE-1737: gfsh query on region that does
not exist may cause NPE
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51044/#review145635
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On Aug. 12, 2016, 4:44 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51044/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2016, 4:44 p.m.)
>
>
> Review request for geode, anilkumar gingade and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> If a query on a region did not exist, a null is returned. This causes an npe that needs to be checked for.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/DataCommands.java ae87b72
>
> Diff: https://reviews.apache.org/r/51044/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>