You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jordan Birdsell (Code Review)" <ge...@cloudera.org> on 2016/12/05 16:44:37 UTC
[kudu-CR] [python] - Add timeouts to Python unit tests
Jordan Birdsell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5362
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
[python] - Add timeouts to Python unit tests
This patch adds a global 100 second timeout to all python unit tests.
This is consistent with the JUnit configuration. If we find that
individual tests need longer than 100 seconds then we can override them.
This configuration was tested in patchset 1, however the forced timeout
will not be committed to master for obvious reasons.
Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
---
M python/kudu/tests/test_scantoken.py
M python/setup.cfg
M python/setup.py
3 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/5362/1
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
[python] - Add timeouts to Python unit tests
This patch adds a global 100 second timeout to all python unit tests.
This is consistent with the JUnit configuration. If we find that
individual tests need longer than 100 seconds then we can override them.
This configuration was tested locally with a forced timeout.
Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Reviewed-on: http://gerrit.cloudera.org:8080/5362
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Todd Lipcon <to...@apache.org>
---
M python/pytest.ini
M python/setup.py
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, but someone else must approve
Todd Lipcon: Looks good to me, approved; Verified
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
Patch Set 4: Code-Review+1
Finally got around to trying this on macOS (sorry!). This runs / passes python tests on macOS. Is there something else I should try?
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
Patch Set 4: Code-Review+2 Verified+1
tested on el6, seems to work
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has uploaded a new patch set (#2).
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
[python] - Add timeouts to Python unit tests
This patch adds a global 100 second timeout to all python unit tests.
This is consistent with the JUnit configuration. If we find that
individual tests need longer than 100 seconds then we can override them.
This configuration was tested in patchset 2, however the forced timeout
will not be committed to master for obvious reasons.
Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
---
M python/kudu/tests/test_scantoken.py
M python/setup.cfg
M python/setup.py
3 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/5362/2
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
Patch Set 4:
No, i just wanted to make sure it didnt hate the SIGALRM
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5362
to look at the new patch set (#4).
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
[python] - Add timeouts to Python unit tests
This patch adds a global 100 second timeout to all python unit tests.
This is consistent with the JUnit configuration. If we find that
individual tests need longer than 100 seconds then we can override them.
This configuration was tested locally with a forced timeout.
Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
---
M python/pytest.ini
M python/setup.py
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/5362/4
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [python] - Add timeouts to Python unit tests
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5362
to look at the new patch set (#3).
Change subject: [python] - Add timeouts to Python unit tests
......................................................................
[python] - Add timeouts to Python unit tests
This patch adds a global 100 second timeout to all python unit tests.
This is consistent with the JUnit configuration. If we find that
individual tests need longer than 100 seconds then we can override them.
This configuration was tested in patchset 2, however the forced timeout
will not be committed to master for obvious reasons.
Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
---
M python/kudu/tests/test_scantoken.py
M python/pytest.ini
M python/setup.cfg
M python/setup.py
4 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/5362/3
--
To view, visit http://gerrit.cloudera.org:8080/5362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibd2a1b7fd7e7e8b2a8ddef9413dc7a863f1968e2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins