[jira] [Commented] (YARN-4645) New findbugs warning in resourcemanager in YARN-2928 branch

["Varun Saxena (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118779#comment-15118779 ] 

Varun Saxena commented on YARN-4645:
------------------------------------

As per my analysis. findbugs issue is due to an unused variable(as the report indicates). This is because the signature of {{RMNodeStatusEvent}} constructor has changed after rebase from trunk. Now instead of passing keep alive app ids' in the constructor, we merely pass the {{NodeStatus}} object in the constructor from which keep alive app ids' are eventually fetched.
So merely removing the declaration of keepAliveApps should be enough.
I can either fix it here or in YARN-4644 itself. Thoughts ?
I can probably run findbugs in all the impacted projects and check if findbugs is coming anywhere else due to rebase. Unlikely because otherwise it would show up in report for YARN-4238

> New findbugs warning in resourcemanager in YARN-2928 branch
> -----------------------------------------------------------
>
>                 Key: YARN-4645
>                 URL: https://issues.apache.org/jira/browse/YARN-4645
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>
> {noformat}
> DLS	Dead store to keepAliveApps in org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
> Bug type DLS_DEAD_LOCAL_STORE (click for details) 
> In class org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService
> In method org.apache.hadoop.yarn.server.resourcemanager.ResourceTrackerService.nodeHeartbeat(NodeHeartbeatRequest)
> Local variable named keepAliveApps
> At ResourceTrackerService.java:[line 486]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)