You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/05 00:14:56 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

dongjoon-hyun opened a new pull request #34808:
URL: https://github.com/apache/spark/pull/34808


   ### What changes were proposed in this pull request?
   
   This PR aims to add `Java 17` SparkR daily test coverage.
   
   ### Why are the changes needed?
   
   To support `Java 17` for SparkR in Apache Spark 3.3.0.
   
   I manually tested SparkR on Java 17 on Apple Silicon M1 Max.
   ```
   $ java -version
   openjdk version "17.0.1" 2021-10-19 LTS
   OpenJDK Runtime Environment Zulu17.30+15-CA (build 17.0.1+12-LTS)
   OpenJDK 64-Bit Server VM Zulu17.30+15-CA (build 17.0.1+12-LTS, mixed mode, sharing)
   ```
   
   ```
   $ build/sbt -Phive -Psparkr test:package
   $ R/install-dev.sh
   $ env SPARK_HOME=$PWD R/run-tests.sh
   ══ Skipped ═════════════════════════════════════════════════════════════════════
   1. sparkJars tag in SparkContext (test_Windows.R:22:5) - Reason: This test is only for Windows, skipped
   
   ══ DONE ════════════════════════════════════════════════════════════════════════
   ...
   + popd
   Tests passed.
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually review. This should be tested after merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986143066


   **[Test build #145924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145924/testReport)** for PR 34808 at commit [`e073a9d`](https://github.com/apache/spark/commit/e073a9d85fa27b891ceb01774f333794035426e4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun removed a comment on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun removed a comment on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986140326


   cc @HyukjinKwon and @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986143066


   **[Test build #145924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145924/testReport)** for PR 34808 at commit [`e073a9d`](https://github.com/apache/spark/commit/e073a9d85fa27b891ceb01774f333794035426e4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986154217


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986155371


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50400/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986160572


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986151355


   Thank you, @HyukjinKwon ! Merged got master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986155371


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50400/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986140326


   cc @HyukjinKwon and @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986158260


   **[Test build #145924 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145924/testReport)** for PR 34808 at commit [`e073a9d`](https://github.com/apache/spark/commit/e073a9d85fa27b891ceb01774f333794035426e4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986147160


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986218171


   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986343464


   FYI, it passed.
   - https://github.com/apache/spark/runs/4422975410?check_suite_focus=true
   ![Screen Shot 2021-12-05 at 4 51 44 PM](https://user-images.githubusercontent.com/9700541/144771317-7ffe5812-3bcf-4918-94c5-8231027318d2.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986343464


   For a record, it passed.
   - https://github.com/apache/spark/runs/4422975410?check_suite_focus=true
   ![Screen Shot 2021-12-05 at 4 51 44 PM](https://user-images.githubusercontent.com/9700541/144771317-7ffe5812-3bcf-4918-94c5-8231027318d2.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986140997


   cc @HyukjinKwon and @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #34808:
URL: https://github.com/apache/spark/pull/34808


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34808: [SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34808:
URL: https://github.com/apache/spark/pull/34808#issuecomment-986160572


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org