You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 14:18:25 UTC
[GitHub] [airflow] potiuk opened a new pull request #13861: Remove azure-storage hack
potiuk opened a new pull request #13861:
URL: https://github.com/apache/airflow/pull/13861
After #12188 has been merged and constraints regenerated, we can
now remove the hack where we had to reinstall azure-storage to
override overlapping versions of azure-storage libraries.
This paves the way to removing last dependency hacks we have in
Airflow.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#issuecomment-766086731
cc: @ephraimbuddy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#discussion_r563214593
##########
File path: Dockerfile
##########
@@ -198,6 +198,11 @@ COPY scripts/docker/install_airflow_from_latest_master.sh /scripts/docker/instal
ARG UPGRADE_TO_NEWER_DEPENDENCIES="false"
ENV UPGRADE_TO_NEWER_DEPENDENCIES=${UPGRADE_TO_NEWER_DEPENDENCIES}
+# By changing CI build epoch we can force reinstalling Airflow from the current master
+# It can also be overwritten manually by setting the AIRFLOW_BUILD_EPOCH environment variable.
+ARG AIRFLOW_BUILD_EPOCH="1"
+ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
Review comment:
Shouldn't it be one of the following two:
```suggestion
ARG AIRFLOW_CI_BUILD_EPOCH="1"
ENV AIRFLOW_CI_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
```
or
```suggestion
ARG AIRFLOW_BUILD_EPOCH="1"
ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_BUILD_EPOCH}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #13861:
URL: https://github.com/apache/airflow/pull/13861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#issuecomment-766611795
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#issuecomment-766611795
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#issuecomment-774657145
Closing in favour of #14102
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13861: Remove azure-storage hack
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13861:
URL: https://github.com/apache/airflow/pull/13861#discussion_r563214659
##########
File path: Dockerfile
##########
@@ -198,6 +198,11 @@ COPY scripts/docker/install_airflow_from_latest_master.sh /scripts/docker/instal
ARG UPGRADE_TO_NEWER_DEPENDENCIES="false"
ENV UPGRADE_TO_NEWER_DEPENDENCIES=${UPGRADE_TO_NEWER_DEPENDENCIES}
+# By changing CI build epoch we can force reinstalling Airflow from the current master
+# It can also be overwritten manually by setting the AIRFLOW_BUILD_EPOCH environment variable.
+ARG AIRFLOW_BUILD_EPOCH="1"
+ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH}
Review comment:
Technically it doesn't matter for cache burst but for consistency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org