[jira] [Commented] (IGNITE-5432) Test IgniteMarshallerCacheClassNameConflictTest failed

["Dmitriy Pavlov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100417#comment-16100417 ] 

Dmitriy Pavlov commented on IGNITE-5432:
----------------------------------------

Hi [~a1vanov],

Thank you for your contribution. It is imporant to have passing tests on continious integration server.

I've checked your PR changes. It seems original test was already fixed under [IGNITE-4947] during suites migration to Ignite Test 2.0.

But in your PR there is additional test introduced GridP2PPeerClassLoadingTest. Is it temprorary test? 
In this test I've found 
- outcommented code, which is better to be removed.
- and also for tests there is common unitity method startGrid(), this is common alternative to Ignition start. This is special version of start to be used on test env. Otherwise Ignite will discover all nodes of other running test and build cluster between Teamcity agents. To provide custom configuration method getConfiguration() may be overriden.

If new test GridP2PPeerClassLoadingTest is still required you can update your changes. If test is not needeed, you may take this considerations into accont for your future contributions.

>  Test IgniteMarshallerCacheClassNameConflictTest failed
> -------------------------------------------------------
>
>                 Key: IGNITE-5432
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5432
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Alexey Ivanov
>            Assignee: Alexey Ivanov
>             Fix For: 2.2
>
>
> Test suit:
> IgniteBinarySimpleNameMapperBasicTestSuite
> Test:
> IgniteMarshallerCacheClassNameConflictTest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)