svn commit: r1065701 - in /commons/proper/net/trunk: RELEASE-NOTES.txt src/main/java/org/apache/commons/net/pop3/POP3Client.java

[se...@apache.org]

Author: sebb
Date: Mon Jan 31 18:20:55 2011
New Revision: 1065701

URL: http://svn.apache.org/viewvc?rev=1065701&view=rev
Log:
NET-351 - APOP authentication fails most of the time
Fix by adding leading 0 if necessary
Patch due to Bogdan Drozdowski

Modified:
    commons/proper/net/trunk/RELEASE-NOTES.txt
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java

Modified: commons/proper/net/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/RELEASE-NOTES.txt?rev=1065701&r1=1065700&r2=1065701&view=diff
==============================================================================
--- commons/proper/net/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/net/trunk/RELEASE-NOTES.txt Mon Jan 31 18:20:55 2011
@@ -21,6 +21,8 @@ o NET-263:  SubnetUtils / SubNetInfo toS
 o Javadoc fixes, improvements, and refactoring. 
 
 Fixed Bugs:
+o NET-351:  APOP authentication fails most of the time
+            Fix by adding leading 0 if necessary. Patch due to Bogdan Drozdowski
 o NET-334:  FromNetASCIIInputStream can throw a NullPointerException 
 o NET-341:  FTPClient.remoteAppend(String filename) uses STOR instead of APPE 
 o NET-339:  Incorrect parsing of timestamp on Windows CE

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java?rev=1065701&r1=1065700&r2=1065701&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java Mon Jan 31 18:20:55 2011
@@ -193,8 +193,11 @@ public class POP3Client extends POP3
         digest = md5.digest(timestamp.getBytes());
         digestBuffer = new StringBuilder(128);
 
-        for (i = 0; i < digest.length; i++)
-            digestBuffer.append(Integer.toHexString(digest[i] & 0xff));
+        for (i = 0; i < digest.length; i++) {
+            int digit = digest[i] & 0xff;
+            if (digit <= 15) digestBuffer.append("0"); // Add leading zero if necessary (NET-351)
+            digestBuffer.append(Integer.toHexString(digit));
+	    }
 
         buffer = new StringBuilder(256);
         buffer.append(username);