You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/06/01 14:25:17 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1481: Fix crash when the perflog mode was enabled
git-hulk opened a new pull request, #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481
The root cause is that we didn't allow the entry when creating
the unique ptr. So it will be a null pointer when the command
was hitting the perflog rule.
This close #1480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1481: Fix crash when the perflog mode was enabled
Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481#issuecomment-1572160841
Good catch! My bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1481: Fix crash when hitting the perflog command rule
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk merged PR #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1481: Fix crash when the perflog mode was enabled
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481#issuecomment-1572170056
> Good catch! My bad.
No problem. I also didn't catch this when reviewing. The main issue is that we didn't have any test cases for this command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] torwig commented on pull request #1481: Fix crash when the perflog mode was enabled
Posted by "torwig (via GitHub)" <gi...@apache.org>.
torwig commented on PR #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481#issuecomment-1572163970
@git-hulk Thanks for reproducing and adding the appropriate test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1481: Fix crash when hitting the perflog command rule
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on PR #1481:
URL: https://github.com/apache/incubator-kvrocks/pull/1481#issuecomment-1572336930
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org