You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/29 15:40:42 UTC

[GitHub] [accumulo] karthick-rn commented on pull request #1717: Remove double quotes on optional arguments from run-verify.sh

karthick-rn commented on pull request #1717:
URL: https://github.com/apache/accumulo/pull/1717#issuecomment-700791682


   > ```shell
   > AUTH_OPT=()
   > [[ -n $VERIFY_AUTHS ]] && AUTH_OPT=('--auths' "$VERIFY_AUTHS")
   > 
   > SCAN_OPT=('--offline')
   > [[ $SCAN_OFFLINE == 'false' ]] && SCAN_OPT=()
   > 
   > "$ACCUMULO_HOME/bin/tool.sh" "$SERVER_LIBJAR" org.apache.accumulo.test.continuous.ContinuousVerify -Dmapreduce.job.reduce.slowstart.completedmaps=0.95 -libjars "$SERVER_LIBJAR" "${AUTH_OPT[@]}" -i "$INSTANCE_NAME" -z "$ZOO_KEEPERS" -u "$USER" -p "$PASS" --table "$TABLE" --output "$VERIFY_OUT" --maxMappers "$VERIFY_MAX_MAPS" --reducers "$VERIFY_REDUCERS" "${SCAN_OPT[@]}"
   > ```
   
   @ctubbsii This is neat & thanks for sharing. Originally I intended to fix this without removing the double quotes but then ran into several issues. Also never thought of using an array to overcome this problem. This is great. I'll change the description of the PR and push an update soon. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org