You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2023/06/14 18:52:51 UTC

[superset] branch master updated: chore: Remove previously deprecated dataset metrics column from RESTful API (#24401)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new fcf7cba8fe chore: Remove previously deprecated dataset metrics column from RESTful API (#24401)
fcf7cba8fe is described below

commit fcf7cba8fe0a7d746edaf903386eba0c41a29083
Author: John Bodley <45...@users.noreply.github.com>
AuthorDate: Wed Jun 14 11:52:42 2023 -0700

    chore: Remove previously deprecated dataset metrics column from RESTful API (#24401)
---
 UPDATING.md              | 1 +
 superset/datasets/api.py | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/UPDATING.md b/UPDATING.md
index 3db0ab6a4b..82360e0711 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -34,6 +34,7 @@ assists people when migrating to a new version.
 
 ### Breaking Changes
 
+- [24401](https://github.com/apache/superset/pull/24401): Removes the deprecated `metrics` column (which was blossomed in [20732](https://github.com/apache/superset/pull/20732)) from the `/api/v1/dataset/` API.
 - [24375](https://github.com/apache/superset/pull/24375): Removed deprecated API `/superset/get_or_create_table/...`, `/superset/sqllab_viz`
 - [24360](https://github.com/apache/superset/pull/24360): Removed deprecated APIs `/superset/stop_query/...`, `/superset/queries/...`, `/superset/search_queries`
 - [24353](https://github.com/apache/superset/pull/24353): Removed deprecated APIs `/copy_dash/int:dashboard_id/`, `/save_dash/int:dashboard_id/`, `/add_slices/int:dashboard_id/`.
diff --git a/superset/datasets/api.py b/superset/datasets/api.py
index 6568ba3793..b44bdf0121 100644
--- a/superset/datasets/api.py
+++ b/superset/datasets/api.py
@@ -163,7 +163,6 @@ class DatasetRestApi(BaseSupersetModelRestApi):
         "columns.type",
         "columns.uuid",
         "columns.verbose_name",
-        "metrics",  # TODO(john-bodley): Deprecate in 3.0.
         "metrics.changed_on",
         "metrics.created_on",
         "metrics.d3format",