You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Lenni Kuff <ls...@cloudera.com> on 2015/01/09 02:40:06 UTC
Re: Review Request 29347: SENTRY-595: [UnitTest] In Kerberos mode,
client should run under clientSubject
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29347/#review67360
-----------------------------------------------------------
Ship it!
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
<https://reviews.apache.org/r/29347/#comment111372>
Looks like some tabs got added, can you remove those?
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java
<https://reviews.apache.org/r/29347/#comment111373>
perhaps rename to runTestAsSubject?
- Lenni Kuff
On Dec. 25, 2014, 10:50 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29347/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2014, 10:50 a.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-595
> https://issues.apache.org/jira/browse/SENTRY-595
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Working with Colin Ma on SENTRY-296, we found client will throw a Kerberos exception when do some operations like renew client in Kerberos related UnitTests. The root cause is in some test cases, client didn't run under clientSubject
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 4a6cac9
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java be14afd
>
> Diff: https://reviews.apache.org/r/29347/diff/
>
>
> Testing
> -------
>
> Unit Tests in local
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 29347: SENTRY-595: [UnitTest] In Kerberos mode,
client should run under clientSubject
Posted by Dapeng Sun <da...@intel.com>.
> On 一月 9, 2015, 9:40 a.m., Lenni Kuff wrote:
> >
Thank you very much for your review, I will update the patch accroding your comments.
> On 一月 9, 2015, 9:40 a.m., Lenni Kuff wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java, line 56
> > <https://reviews.apache.org/r/29347/diff/1/?file=799135#file799135line56>
> >
> > Looks like some tabs got added, can you remove those?
Hi Lenni, I checked the patch, there is no tabs, maybe it's an issue of review board.
> On 一月 9, 2015, 9:40 a.m., Lenni Kuff wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java, line 280
> > <https://reviews.apache.org/r/29347/diff/1/?file=799136#file799136line280>
> >
> > perhaps rename to runTestAsSubject?
Good suggestion, I will update the patch
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29347/#review67360
-----------------------------------------------------------
On 十二月 25, 2014, 6:50 p.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29347/
> -----------------------------------------------------------
>
> (Updated 十二月 25, 2014, 6:50 p.m.)
>
>
> Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-595
> https://issues.apache.org/jira/browse/SENTRY-595
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Working with Colin Ma on SENTRY-296, we found client will throw a Kerberos exception when do some operations like renew client in Kerberos related UnitTests. The root cause is in some test cases, client didn't run under clientSubject
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java 4a6cac9
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java be14afd
>
> Diff: https://reviews.apache.org/r/29347/diff/
>
>
> Testing
> -------
>
> Unit Tests in local
>
>
> Thanks,
>
> Dapeng Sun
>
>