[jira] [Commented] (CRUNCH-118) Add Aggregator and lib functionality for computing the distinct elements of a PCollection

["Matthias Friedrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502214#comment-13502214 ] 

Matthias Friedrich commented on CRUNCH-118:
-------------------------------------------

Looks great. Unless someone beats me to it I'll have a closer look this weekend.

A couple of things I noticed: The SetAggregator's second constructor isn't used, did you mean to add a UNIQUE_ELEMENTS(sizeLimit) factory? Also, you could add a private constructor for Distinct and make it final. Thanks BTW for fixing my javadoc bugs :)
                
> Add Aggregator and lib functionality for computing the distinct elements of a PCollection
> -----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-118
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-118
>             Project: Crunch
>          Issue Type: Improvement
>          Components: MapReduce Patterns
>            Reporter: Josh Wills
>         Attachments: CRUNCH-118.patch
>
>
> In my continuing effort to add functions that I like from Hive/Pig to Crunch, I'm proposing a) an Aggregator that behaves like Hive's collect_set() UDAF and b) an o.a.c.lib.Distinct library for computing the distinct elements of a PCollection via a groupByKey operation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira