You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/10/19 07:56:35 UTC
[GitHub] [incubator-kyuubi] cfmcgrady commented on a change in pull request #1256: [KYUUBI #1252] Move KyuubiConf#toSparkPrefixedConf out of kyuubi-common module
cfmcgrady commented on a change in pull request #1256:
URL: https://github.com/apache/incubator-kyuubi/pull/1256#discussion_r731592001
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -123,10 +123,20 @@ class SparkProcessBuilder(
buffer += executable
buffer += CLASS
buffer += mainClass
- conf.toSparkPrefixedConf.foreach { case (k, v) =>
+ // add `spark.` prefix for all the config keys.
+ conf.getAll.foreach { case (k, v) =>
+ var newKey = ""
+ if (k.startsWith("spark.")) {
+ newKey = k
+ } else if (k.startsWith("hadoop.")) {
Review comment:
It seems that we don't need to deal with this situation separately?
We always add `spark.` prefix to the key if it does not start with `spark.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org