You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/24 01:35:06 UTC
[GitHub] [airflow] kaxil opened a new pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
kaxil opened a new pull request #14970:
URL: https://github.com/apache/airflow/pull/14970
The default value for `[webserver] worker_refresh_interval` was `30` seconds for
Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
and the Webserver used the serialized DAGs, there is no need to kill an existing
worker and create a new one as frequently as `30` seconds.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#discussion_r600088631
##########
File path: UPDATING.md
##########
@@ -70,6 +70,16 @@ https://developers.google.com/style/inclusive-documentation
-->
+### Default `[webserver] worker_refresh_interval` is changed to `6000` seconds
+
+The default value for `[webserver] worker_refresh_interval` was `30` seconds for
+Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
Review comment:
Should this be in 2.0.2 (or 2.1) as it is not a bugfix but a good optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj removed a comment on pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
mik-laj removed a comment on pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#issuecomment-808504658
In addition to the DAG, this also affects plugins, which will now update noticeably slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#issuecomment-805443278
[The Workflow run](https://github.com/apache/airflow/actions/runs/681594826) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#issuecomment-805781824
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#discussion_r600088631
##########
File path: UPDATING.md
##########
@@ -70,6 +70,16 @@ https://developers.google.com/style/inclusive-documentation
-->
+### Default `[webserver] worker_refresh_interval` is changed to `6000` seconds
+
+The default value for `[webserver] worker_refresh_interval` was `30` seconds for
+Airflow <=2.0.1. However, since Airflow 2.0 DAG Serialization is a hard requirement
Review comment:
Should this be in 2.0.2 (or 2.1) as it is not a bugfix but a good optimization?
This wouldn't affect the current deployment that have `[webserver] worker_refresh_interval` set in their `airflow.cfg` but affects new deployments and existing deployments that don't have it in `airflow.cfg` and rely on the default fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #14970:
URL: https://github.com/apache/airflow/pull/14970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #14970: Increase default `worker_refresh_interval` to `6000` seconds
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #14970:
URL: https://github.com/apache/airflow/pull/14970#issuecomment-808504658
In addition to the DAG, this also affects plugins, which will now update noticeably slower.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org