You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Hervé Boutemy <he...@free.fr> on 2023/02/01 07:09:17 UTC
Re: [VOTE] Release Apache Maven 4.0.0-alpha-4 release
Le lundi 30 janvier 2023, 08:32:59 CET Guillaume Nodet a écrit :
> I'm not sure we're talking about the same thing.
I'm not sure either, I need to review even more carefully :)
>
> The plugin's goals child has been deprecated and unused since 15 years
> afaik:
>
> https://github.com/apache/maven/commit/d2e1f3c97556afa42972a9ef20d336fccaed4
> ad5
oh, I now see that it's declared as DOM in the model and commented as
deprecated for a long time
https://maven.apache.org/ref/3.8.7/maven-model/maven.html#class_plugin
https://maven.apache.org/ref/3.0.1/maven-model/maven.html#class_plugin
And re-reading the misc documentations on our website, I see that we always
show goals in execution, never outside: sorry, it's my memory that seems to
have read too much the generated XML at the beginning of
https://maven.apache.org/ref/3.8.7/maven-model/maven.html
without seeing that this goals field is deprecated and never used :)
Thanks for the explanation and cleanup
>
> https://github.com/apache/maven/commit/cbcc49b306ce2c6c2fb32212c089c11978524
> c92
>
> The deprecated elements have been removed during the introduction of the v4
> api:
>
> https://github.com/apache/maven/commit/2a9f39336cec1d8e52d30cc48503d51ed8672
> 536#diff-ccc5b1903a864adb4a01d6072c9c2ff937c71fb06bea6e5ec3df6097f0d01199
>
> It should be quite easy to add some compatibility, if that's needed.
>
> Guillaume
>
> Le lun. 30 janv. 2023 à 08:02, Hervé Boutemy <he...@free.fr> a
>
> écrit :
> > sorry, I don't get why declaring a build plugin with a goal is rejected
> > with
> > Maven 4: AFAIK, it's something that has been used since Maven 2 and I
> > don't
> > see any problem with it .
> >
> >
> > What's the reasoning, please?
> > (ideally what's the Jira issue leading to that effect?)
> >
> > Regards,
> >
> > Hervé
> >
> > Le dimanche 29 janvier 2023, 20:24:54 CET Guillaume Nodet a écrit :
> > > Yes, I already reported and provided a fix on netty.
> > >
> > > https://github.com/netty/netty/pull/12911
> > >
> > > So recent netty versions don't have this problem anymore.
> > >
> > > Le dim. 29 janv. 2023 à 19:59, Romain Manni-Bucau
> > > <rm...@gmail.com>
> >
> > a
> >
> > > écrit :
> > > > Hi Delany,
> > > >
> > > > yes but since it is deprecated and *unused by maven*, I think it is
> >
> > really
> >
> > > > an error in netty pom and unintended so think it is an ok behavior (
> >
> > https://github.com/apache/maven/commit/f153ac134c26ed89cdb7de1b294ecb61320
> >
> > 8c22b#diff-91081af7c7d8c77b1b3cff89dd3b257e2967696c2f6d48aa65e827e1e2915a7
> >
> > > > aR133 ).
> > > >
> > > > Romain Manni-Bucau
> > > > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > > <http://rmannibucau.wordpress.com> | Github <
> > > > https://github.com/rmannibucau> |
> > > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > > <
> >
> > https://www.packtpub.com/application-development/java-ee-8-high-performanc
> >
> > > > e
> > > >
> > > >
> > > >
> > > > Le dim. 29 janv. 2023 à 19:49, Delany <de...@gmail.com> a
> > > >
> > > > écrit :
> > > > > Hi Romain. As far as I know executions are not required.
> > > > > The relationship: plugin > goals is valid against
> > > > > https://maven.apache.org/maven-v4_0_0.xsd
> > > > > Delany
> > > > >
> > > > > On Sun, 29 Jan 2023 at 16:40, Romain Manni-Bucau <
> >
> > rmannibucau@gmail.com>
> >
> > > > > wrote:
> > > > > > +1
> > > > > >
> > > > > > @Delany netty bom looks incorrect (misses execution(s).
> > > > > >
> > > > > > Le dim. 29 janv. 2023 à 13:53, Karl Heinz Marbaise <
> >
> > khmarbaise@gmx.de>
> >
> > > > a
> > > >
> > > > > > écrit :
> > > > > > > Hi,
> > > > > > >
> > > > > > > +1 from me.
> > > > > > >
> > > > > > > Kind regards
> > > > > > > Karl Heinz Marbaise
> > > > > > >
> > > > > > > On 27.01.23 18:11, Guillaume Nodet wrote:
> > > > > > > > I've staged a release candidate at [1]. The distributions are
> > > > > >
> > > > > > available
> > > > > >
> > > > > > > at
> > > > > > >
> > > > > > > > [2].
> > > > > > > > The release notes are available at [3] for JIRA and [4] for
> > > > > > > > github.
> > > > > > > >
> > > > > > > > Please review and vote !
> > > > > > > >
> > > > > > > > Cheers,
> > > > > > > > Guillaume
> > > > > > > >
> > > > > > > > [1]
> >
> > https://repository.apache.org/content/repositories/maven-1859
> >
> > > > > > > > [2]
> >
> > https://dist.apache.org/repos/dist/dev/maven/maven-4/4.0.0-alpha-4/
> >
> > > > > > > > [3]
> >
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12352667&st
> >
> > > > yleName=Text&projectId=12316922>
> > > >
> > > > > > > > [4]
> >
> > https://github.com/apache/maven/releases/tag/untagged-4ba8d14c9e8eb6de3887
> >
> >
> > --------------------------------------------------------------------
> >
> > > > > > > -
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org