You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jegonzal <gi...@git.apache.org> on 2014/04/23 08:02:15 UTC
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
GitHub user jegonzal opened a pull request:
https://github.com/apache/spark/pull/499
SPARK-1577: Enabling reference tracking by default in GraphX KryoRegistrator.
We had originally disabled reference tracking by default however this now seems to create serious issues in the spark-shell where even the following benign block of code will fail:
```scala
class A(a: String) extends Serializable
val x = sc.parallelize(Array.fill(10)(new A("hello")))
x.collect
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jegonzal/spark graphx-kryo-issue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 8779a836ff6d134b445a051a13c5d85130a9f848
Author: Joseph E. Gonzalez <jo...@gmail.com>
Date: 2014-04-23T05:59:24Z
Enabling reference tracking by default in GraphX KryoRegistrator.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by jegonzal <gi...@git.apache.org>.
Github user jegonzal closed the pull request at:
https://github.com/apache/spark/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41129561
All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14359/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-42790193
@jegonzal @rxin is this still needed for GraphX to work in the shell in 1.0 or do you guys have a workaround?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41127523
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41361356
We could do that too, but how would we detect that we're in the shell here? Maybe one way is to set the track references SparkConf field to false and don't override it here if it is set.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41243517
Is the problem A has a reference to the outer level repl object? Maybe a better solution here is to turn reference tracking off when we serialize closures in the shell mode ... @mateiz thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41129559
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-41127530
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-1577: Enabling reference tracking by def...
Posted by mateiz <gi...@git.apache.org>.
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/499#issuecomment-42791416
Actually it looks like this will be subsumed by https://github.com/apache/spark/pull/724. You should close this pull request, as GitHub won't automatically close it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---