You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/21 07:01:03 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #37595: [WIP][SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
MaxGekk opened a new pull request, #37595:
URL: https://github.com/apache/spark/pull/37595
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
Yes.
### How was this patch tested?
By running new tests:
```
$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z percentiles.sql"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37595:
URL: https://github.com/apache/spark/pull/37595#issuecomment-1221921111
> Do we need to update migration guide?
@HyukjinKwon The feature hasn't released yet. See the PR when support of ANSI types was added: https://github.com/apache/spark/pull/36965. The changes are not in 3.3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
URL: https://github.com/apache/spark/pull/37595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37595:
URL: https://github.com/apache/spark/pull/37595#discussion_r951064662
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -59,7 +59,8 @@ abstract class PercentileBase
override lazy val dataType: DataType = {
val resultType = child.dataType match {
- case it: AnsiIntervalType => it
+ case _: YearMonthIntervalType => YearMonthIntervalType()
+ case _: DayTimeIntervalType => DayTimeIntervalType()
Review Comment:
It could make sense, but the current approach is we return the default type (interval day to second) in many places. See `mean()` (PR's description), for instance. cc @srielau
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37595:
URL: https://github.com/apache/spark/pull/37595#issuecomment-1222002714
Merging to master. Thank you, @cloud-fan @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37595:
URL: https://github.com/apache/spark/pull/37595#discussion_r951030541
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -59,7 +59,8 @@ abstract class PercentileBase
override lazy val dataType: DataType = {
val resultType = child.dataType match {
- case it: AnsiIntervalType => it
+ case _: YearMonthIntervalType => YearMonthIntervalType()
+ case _: DayTimeIntervalType => DayTimeIntervalType()
Review Comment:
shall we still respect the start field? e.g. `median(interval minute)` returns internal minute to second`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #37595:
URL: https://github.com/apache/spark/pull/37595#discussion_r951064662
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -59,7 +59,8 @@ abstract class PercentileBase
override lazy val dataType: DataType = {
val resultType = child.dataType match {
- case it: AnsiIntervalType => it
+ case _: YearMonthIntervalType => YearMonthIntervalType()
+ case _: DayTimeIntervalType => DayTimeIntervalType()
Review Comment:
It could make sense, but the current approach is we return the default type (interval day to second) in many places. See `mean()` (PR's description), for instance. cc @srielau
@cloud-fan If you propose to change the current approach, need to modify all place in one shot in a separate PR. For now, this PR makes the `percentile` functions consistent to others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #37595: [SPARK-40151][SQL] Return wider ANSI interval types from the percentile functions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #37595:
URL: https://github.com/apache/spark/pull/37595#discussion_r951094230
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -59,7 +59,8 @@ abstract class PercentileBase
override lazy val dataType: DataType = {
val resultType = child.dataType match {
- case it: AnsiIntervalType => it
+ case _: YearMonthIntervalType => YearMonthIntervalType()
+ case _: DayTimeIntervalType => DayTimeIntervalType()
Review Comment:
Ah I see, let's follow the existing decision for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org