You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/30 08:37:22 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #29909: Spark 33023
AngersZhuuuu opened a new pull request #29909:
URL: https://github.com/apache/spark/pull/29909
### What changes were proposed in this pull request?
according to https://github.com/apache/spark/pull/29881#discussion_r496648397
we need add condition `Utils.isWindows`
### Why are the changes needed?
add strict condition of judging path is window path
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701285926
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33885/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #29909: [SPARK-33023][CORE] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #29909:
URL: https://github.com/apache/spark/pull/29909#discussion_r497951985
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1899,7 +1899,7 @@ class SparkContext(config: SparkConf) extends Logging {
if (path == null || path.isEmpty) {
logWarning("null or empty path specified as parameter to addJar")
} else {
- val key = if (path.contains("\\")) {
+ val key = if (path.contains("\\") && Utils.isWindows) {
Review comment:
> @AngersZhuuuu . This is `CORE` instead of `SQL`.
>
> * `core/src/main/scala/org/apache/spark/SparkContext.scala`
Sorry, since always work at `SQL` module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701285943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701250507
**[Test build #129268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129268/testReport)** for PR 29909 at commit [`27ebe48`](https://github.com/apache/spark/commit/27ebe4858cb46e998a6dc3ecd8f7bd110d05bfe4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701308219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29909: [SPARK-33023][CORE] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29909:
URL: https://github.com/apache/spark/pull/29909#discussion_r497949054
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1899,7 +1899,7 @@ class SparkContext(config: SparkConf) extends Logging {
if (path == null || path.isEmpty) {
logWarning("null or empty path specified as parameter to addJar")
} else {
- val key = if (path.contains("\\")) {
+ val key = if (path.contains("\\") && Utils.isWindows) {
Review comment:
@AngersZhuuuu . This is `CORE` instead of `SQL`.
- `core/src/main/scala/org/apache/spark/SparkContext.scala`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701308219
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701307810
**[Test build #129268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129268/testReport)** for PR 29909 at commit [`27ebe48`](https://github.com/apache/spark/commit/27ebe4858cb46e998a6dc3ecd8f7bd110d05bfe4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29909: [SPARK-33023][CORE] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29909:
URL: https://github.com/apache/spark/pull/29909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701275883
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33885/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701250507
**[Test build #129268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129268/testReport)** for PR 29909 at commit [`27ebe48`](https://github.com/apache/spark/commit/27ebe4858cb46e998a6dc3ecd8f7bd110d05bfe4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701285943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701249558
FYI @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29909: [SPARK-33023][SQL] Judge path of Windows need add condition `Utils.isWindows`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29909:
URL: https://github.com/apache/spark/pull/29909#issuecomment-701308227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129268/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org